You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/09 11:44:30 UTC

[I] fix: reject non-Apache instances from Remoting admin resolution [rocketmq-dashboard]

Aias00 opened a new issue, #1295:
URL: https://github.com/apache/rocketmq-dashboard/issues/1295

   ## Problem
   
   RuntimeAdminClientResolver validates only instance ID and endpoint. A cloud-backed instance can therefore reach MqAdminExtFactory, which treats its endpoint as a RocketMQ NameServer address. This bypasses the provider boundary and fails with an incorrect protocol path.
   
   ## Expected behavior
   
   Remoting MQAdmin operations are available only for APACHE instances. Cloud instances must be handled by their provider implementation and receive an actionable structured error when a Remoting-only operation is requested.
   
   ## Scope
   
   - Enforce the APACHE vendor boundary in RuntimeAdminClientResolver.
   - Preserve existing Apache instance behavior.
   - Add regression tests for cloud instance rejection.
   
   ## Evidence
   
   - server/src/main/java/org/apache/rocketmq/studio/cluster/broker/RuntimeAdminClientResolver.java
   - The resolver is used by the Apache metadata, message, DLQ, client, and dashboard providers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] fix: reject non-Apache instances from Remoting admin resolution [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.

RockteMQ-AI commented on issue #1295:
URL: https://github.com/apache/rocketmq-dashboard/issues/1295#issuecomment-5231447005

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   The reported boundary violation is valid. `RuntimeAdminClientResolver` in the `rocketmq-studio` branch validates only instance ID and endpoint, without checking the vendor/instance type. This allows cloud-backed instances to reach `MqAdminExtFactory` through the Remoting protocol path, which is incorrect.
   
   **Root Cause:** Missing vendor type check in `RuntimeAdminClientResolver` — cloud instances should be rejected from Remoting admin operations.
   **Impact:** Any non-Apache instance selected in the dashboard could trigger incorrect protocol handling and confusing errors.
   **Severity:** medium
   
   A fix is already proposed in PR #1296 (`fix: reject cloud instances from Remoting admin resolution`), which adds the `RuntimeAdminClientResolverTest` for regression coverage.
   
   ---
   *Automated evaluation by github-manager-bot*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] fix: reject non-Apache instances from Remoting admin resolution [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.

lizhimins commented on issue #1295:
URL: https://github.com/apache/rocketmq-dashboard/issues/1295#issuecomment-5236065873

   Resolved by #1403 (merged into rocketmq-studio as ace3fb91).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] fix: reject non-Apache instances from Remoting admin resolution [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.

lizhimins closed issue #1295: fix: reject non-Apache instances from Remoting admin resolution
URL: https://github.com/apache/rocketmq-dashboard/issues/1295


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org