You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Rohit-pawar902 (via GitHub)" <gi...@apache.org> on 2023/02/22 12:22:49 UTC
[GitHub] [superset] Rohit-pawar902 opened a new pull request, #23155: fix :Extra column in csv while sending csv on email
Rohit-pawar902 opened a new pull request, #23155:
URL: https://github.com/apache/superset/pull/23155
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
While sending Csv on Email getting an extra column which has a count from 0 to n-row .
Which I should not want.( And I think no one wants in CSV because we get numbering while opening it on platforms )
I have fix this thing and added CSV_INDEX={"index":False} //In superset_config.py
Which make to not create an index
If You want index in csv make it True.
For More detail on this fix Refer this issue
https://github.com/apache/superset/issues/22981
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
- Simply Checked By sending chart as csv on email extra index-column is not coming
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: https://github.com/apache/superset/issues/22981
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rohitpawar2811 commented on pull request #23155: fix: Extra column in csv(or non-raw csv) get while sending on email
Posted by "rohitpawar2811 (via GitHub)" <gi...@apache.org>.
rohitpawar2811 commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-1491310583
@betodealmeida
I have updated the PR with suggested changes, could you please review it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "rohitpawar2811 (via GitHub)" <gi...@apache.org>.
rohitpawar2811 commented on code in PR #23155:
URL: https://github.com/apache/superset/pull/23155#discussion_r1555205570
##########
superset/commands/report/execute.py:
##########
@@ -254,6 +255,14 @@ def _get_csv_data(self) -> bytes:
try:
logger.info("Getting chart from %s as user %s", url, user.username)
csv_data = get_chart_csv_data(chart_url=url, auth_cookies=auth_cookies)
+ if csv_data:
+ buf = BytesIO()
+ temp_df = pd.read_csv(StringIO(csv_data.decode("utf-8")))
+ if temp_df.columns[0].strip() == "Unnamed: 0":
Review Comment:
okay got your point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "SkinnyPigeon (via GitHub)" <gi...@apache.org>.
SkinnyPigeon commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-2154787008
Hey folks, we have an account manager that has raised this as a concern. Do you think that there will be any updates on this going forward?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "rohitpawar2811 (via GitHub)" <gi...@apache.org>.
rohitpawar2811 commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-1742851787
@betodealmeida
I have updated my changes as previously the test-cases were failing, could you re-run the workflow tests on my latest changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rohitpawar2811 commented on pull request #23155: fix :Extra column in csv while sending csv on email
Posted by "rohitpawar2811 (via GitHub)" <gi...@apache.org>.
rohitpawar2811 commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-1448215200
`Hey @rohitpawar2811 ! we could use True/False in case some users got used to the row_number already? as @betodealmeida said, we can change that in future releases along addressing the other problems listed in the issue. Let's add some tests for both cases if possible. Thanks again!`
got your point related True/False
Now For Test-Case :
1. I think we can create chart with sample data and then
2. we have to simple call the api(/api/v1/chart/628/data/?format=json&type=post_processed&force=false) for download csv.
3. after downloading csv we would again create dataframe and then check the count of columns in dataframe
4. count of columns in dataframe we would compare with same data of csv.
5. we would repeat this for both True/false value of config
I think this test-case is only possible check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mike-fischer1 commented on pull request #23155: fix: Extra column in csv(or non-raw csv) get while sending on email
Posted by "mike-fischer1 (via GitHub)" <gi...@apache.org>.
mike-fischer1 commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-1731963546
any updates on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "romran (via GitHub)" <gi...@apache.org>.
romran commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-1840324234
Hello everyone :)
Any updates on this issue? We are using Version: 3.0.1 and getting index column in csv file when sending email report.
Maybe someone know if there another fix? Or should we finish this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-1927586124
Enabling CI checks.... 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23155: fix :Extra column in csv while sending csv on email
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-1458633514
# [Codecov](https://codecov.io/gh/apache/superset/pull/23155?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23155](https://codecov.io/gh/apache/superset/pull/23155?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (90bf535) into [master](https://codecov.io/gh/apache/superset/commit/a0ca0c04ff97c4d18c9567035e8b702bdca7f181?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a0ca0c0) will **decrease** coverage by `11.31%`.
> The diff coverage is `34.80%`.
> :exclamation: Current head 90bf535 differs from pull request most recent head 3a564dc. Consider uploading reports for the commit 3a564dc to get more accurate results
```diff
@@ Coverage Diff @@
## master #23155 +/- ##
===========================================
- Coverage 67.49% 56.18% -11.31%
===========================================
Files 1898 1906 +8
Lines 73072 73413 +341
Branches 7945 7958 +13
===========================================
- Hits 49320 41248 -8072
- Misses 21716 30124 +8408
- Partials 2036 2041 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.63% <43.01%> (-0.11%)` | :arrow_down: |
| python | `58.82% <48.74%> (-23.51%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `52.49% <48.74%> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../packages/superset-ui-core/src/chart/types/Base.ts](https://codecov.io/gh/apache/superset/pull/23155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY2hhcnQvdHlwZXMvQmFzZS50cw==) | `100.00% <ø> (ø)` | |
| [...ackages/superset-ui-core/src/utils/featureFlags.ts](https://codecov.io/gh/apache/superset/pull/23155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvZmVhdHVyZUZsYWdzLnRz) | `100.00% <ø> (ø)` | |
| [...gins/legacy-plugin-chart-world-map/src/WorldMap.js](https://codecov.io/gh/apache/superset/pull/23155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXdvcmxkLW1hcC9zcmMvV29ybGRNYXAuanM=) | `0.00% <0.00%> (ø)` | |
| [...plugins/legacy-plugin-chart-world-map/src/index.js](https://codecov.io/gh/apache/superset/pull/23155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXdvcmxkLW1hcC9zcmMvaW5kZXguanM=) | `66.66% <ø> (ø)` | |
| [...egacy-plugin-chart-world-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/23155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXdvcmxkLW1hcC9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...lugin-chart-echarts/src/BigNumber/BigNumberViz.tsx](https://codecov.io/gh/apache/superset/pull/23155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQmlnTnVtYmVyL0JpZ051bWJlclZpei50c3g=) | `0.00% <0.00%> (ø)` | |
| [...lugin-chart-echarts/src/BoxPlot/EchartsBoxPlot.tsx](https://codecov.io/gh/apache/superset/pull/23155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQm94UGxvdC9FY2hhcnRzQm94UGxvdC50c3g=) | `0.00% <0.00%> (ø)` | |
| [.../plugin-chart-echarts/src/Funnel/EchartsFunnel.tsx](https://codecov.io/gh/apache/superset/pull/23155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvRnVubmVsL0VjaGFydHNGdW5uZWwudHN4) | `0.00% <0.00%> (ø)` | |
| [...ns/plugin-chart-echarts/src/Gauge/EchartsGauge.tsx](https://codecov.io/gh/apache/superset/pull/23155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvR2F1Z2UvRWNoYXJ0c0dhdWdlLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...ns/plugin-chart-echarts/src/Graph/EchartsGraph.tsx](https://codecov.io/gh/apache/superset/pull/23155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvR3JhcGgvRWNoYXJ0c0dyYXBoLnRzeA==) | `0.00% <0.00%> (ø)` | |
| ... and [408 more](https://codecov.io/gh/apache/superset/pull/23155?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "SkinnyPigeon (via GitHub)" <gi...@apache.org>.
SkinnyPigeon commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-2157935166
Hey @rusackas, @rohitpawar2811, playing about with the API a bit, it seems that there is an Enum called [POST_PROCESSED](https://github.com/apache/superset/blob/5660f8e5542b78e098c42306633c182d9a631d63/superset/common/chart_data.py#L45) that is what is causing the additional index to be added. This is set [here](https://github.com/apache/superset/blob/5660f8e5542b78e098c42306633c182d9a631d63/superset/commands/report/execute.py#L162) in the report execution for the CSV datatype. If this is left blank, at least in the API, it returns the same data minus the index.
We could add the config check to this point instead. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "SkinnyPigeon (via GitHub)" <gi...@apache.org>.
SkinnyPigeon commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-2160048987
> > Hey @rusackas, @rohitpawar2811, playing about with the API a bit, it seems that there is an Enum called [POST_PROCESSED](https://github.com/apache/superset/blob/5660f8e5542b78e098c42306633c182d9a631d63/superset/common/chart_data.py#L45) that is what is causing the additional index to be added. This is set [here](https://github.com/apache/superset/blob/5660f8e5542b78e098c42306633c182d9a631d63/superset/commands/report/execute.py#L162) in the report execution for the CSV datatype. If this is left blank, at least in the API, it returns the same data minus the index.
> > We could add the config check to this point instead. WDYT?
>
> @SkinnyPigeon I think this should work, but we need to check the test cases. Actually, in the past, I made changes inside to the post-processing logic, but I think your suggested check here makes more sense.
>
> **Disturbing Part :**
>
> * Making check on uri will remove csv index as well dataframe index.
>
> Should we remove the DataFrame (text-email) index as well? What do you think?
With regards to where to make the change, I would suggest [here](https://github.com/apache/superset/blob/5660f8e5542b78e098c42306633c182d9a631d63/superset/commands/report/execute.py#L253). You could leave that line as is but then have a check for the config setting underneath and pass the URL to a function like this if we want the index removed:
``` python
def remove_post_processed(url: str) -> str:
"""Remove the type=post_processed parameter from the URL query string.
Args:
url (str): The URL to process.
Returns:
str: The URL with the type=post_processed parameter removed."""
if "?" not in url:
return url
base_url, query_string = url.split("?", 1)
params = query_string.split("&")
filtered_params = [param for param in params if param != "type=post_processed"]
filtered_query_string = "&".join(filtered_params)
filtered_url = f"{base_url}?{filtered_query_string}"
return filtered_url
```
This gives us something nice and easy to write some tests for:
```python
def test_remove_post_processed():
url = "https://superset.com/?param1=value1&type=post_processed¶m2=value2"
expected = "https://superset.com/?param1=value1¶m2=value2"
assert remove_post_processed(url) == expected
def test_retain_other_parameters():
url = "https://superset.com/?param1=value1¶m2=value2"
expected = "https://superset.com/?param1=value1¶m2=value2"
assert remove_post_processed(url) == expected
def test_no_post_processed_present():
url = "https://superset.com/?param1=value1¶m2=value2"
expected = "https://superset.com/?param1=value1¶m2=value2"
assert remove_post_processed(url) == expected
def test_empty_query_string():
url = "https://superset.com/?"
expected = "https://superset.com/?"
assert remove_post_processed(url) == expected
def test_no_query_string():
url = "https://superset.com"
expected = "https://superset.com"
assert remove_post_processed(url) == expected
```
I'd leave the design decisions to the the code owners in terms of whether to remove it from the DataFrame as well, but I'd say the CSV is probably a good place to start for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "rohitpawar2811 (via GitHub)" <gi...@apache.org>.
rohitpawar2811 commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-1746786180
@rusackas can you run checks on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "rohitpawar2811 (via GitHub)" <gi...@apache.org>.
rohitpawar2811 commented on code in PR #23155:
URL: https://github.com/apache/superset/pull/23155#discussion_r1492055274
##########
superset/commands/report/execute.py:
##########
@@ -254,6 +255,14 @@ def _get_csv_data(self) -> bytes:
try:
logger.info("Getting chart from %s as user %s", url, user.username)
csv_data = get_chart_csv_data(chart_url=url, auth_cookies=auth_cookies)
+ if csv_data:
+ buf = BytesIO()
+ temp_df = pd.read_csv(StringIO(csv_data.decode("utf-8")))
+ if temp_df.columns[0].strip() == "Unnamed: 0":
Review Comment:
>> Are we certain that no matter what the CVS file is, this is the value it gets with numbered columns?
Yes I am sure about, and not able to find a better way to check that index column is present in csv or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "rohitpawar2811 (via GitHub)" <gi...@apache.org>.
rohitpawar2811 commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-1744261059
> any updates on this?
@mike-fischer1 @Antonio-RiveroMartnez
These changes would work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "rohitpawar2811 (via GitHub)" <gi...@apache.org>.
rohitpawar2811 commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-1758941844
@betodealmeida could you please re-run the checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-2155423043
I think @betodealmeida's change request is blocking it. It looks like CI will need to run again, but there seem to be a few unanswered questions on the thread. @SkinnyPigeon feel free to give it a code review if you'd like, that always helps. Mabye @Antonio-RiveroMartnez or @eschutho know where this stands in someone's/anyone's queue otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>.
Antonio-RiveroMartnez commented on code in PR #23155:
URL: https://github.com/apache/superset/pull/23155#discussion_r1491270037
##########
tests/integration_tests/fixtures/trends.csv:
##########
Review Comment:
Shouldn't this file have some content?
##########
superset/commands/report/execute.py:
##########
@@ -254,6 +255,14 @@ def _get_csv_data(self) -> bytes:
try:
logger.info("Getting chart from %s as user %s", url, user.username)
csv_data = get_chart_csv_data(chart_url=url, auth_cookies=auth_cookies)
+ if csv_data:
+ buf = BytesIO()
+ temp_df = pd.read_csv(StringIO(csv_data.decode("utf-8")))
+ if temp_df.columns[0].strip() == "Unnamed: 0":
Review Comment:
Why `Unnamed: 0`? Can we move it out of the function and make it clear why is that the value we're comparing? Are we certain that no matter what the CVS file is, this is the value it gets with numbered columns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Rohit-pawar902 commented on a diff in pull request #23155: fix :Extra column in csv while sending csv on email
Posted by "Rohit-pawar902 (via GitHub)" <gi...@apache.org>.
Rohit-pawar902 commented on code in PR #23155:
URL: https://github.com/apache/superset/pull/23155#discussion_r1119592497
##########
superset/config.py:
##########
@@ -748,6 +748,10 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
# note: index option should not be overridden
CSV_EXPORT = {"encoding": "utf-8"}
+#It Is used for enable/disable the index sequence for csv which came at email-time,
+#rearly someone want the index in csv so by-default it is false
+CSV_INDEX={"index":False}
+
Review Comment:
@betodealmeida Your all changes looks good and thanks for responce.
But According to this comment :
https://github.com/apache/superset/issues/22981#issuecomment-1440410419
I would thing we don't have to give config `opt true/false` , instead we can make this `processed_df.to_csv(buf, index=config["CSV_INDEX"]) ` to processed_df.to_csv(buf, index=False) Because it is really a bug.
what do you think ? I like to listen your thougts regarding to this.
@Antonio-RiveroMartnez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #23155: fix :Extra column in csv while sending csv on email
Posted by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>.
Antonio-RiveroMartnez commented on code in PR #23155:
URL: https://github.com/apache/superset/pull/23155#discussion_r1119917058
##########
superset/config.py:
##########
@@ -748,6 +748,10 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
# note: index option should not be overridden
CSV_EXPORT = {"encoding": "utf-8"}
+#It Is used for enable/disable the index sequence for csv which came at email-time,
+#rearly someone want the index in csv so by-default it is false
+CSV_INDEX={"index":False}
+
Review Comment:
Hey @rohitpawar2811 ! we could use `True/False` in case some users got used to the `row_number` already? as @betodealmeida said, we can change that in future releases along addressing the other problems listed in the issue. Let's add some tests for both cases if possible. Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a diff in pull request #23155: fix :Extra column in csv while sending csv on email
Posted by "betodealmeida (via GitHub)" <gi...@apache.org>.
betodealmeida commented on code in PR #23155:
URL: https://github.com/apache/superset/pull/23155#discussion_r1119254393
##########
superset/config.py:
##########
@@ -748,6 +748,10 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
# note: index option should not be overridden
CSV_EXPORT = {"encoding": "utf-8"}
+#It Is used for enable/disable the index sequence for csv which came at email-time,
+#rearly someone want the index in csv so by-default it is false
+CSV_INDEX={"index":False}
+
Review Comment:
Let's keep the current behavior as the default, even if it's weird. We can change the default in 3.0:
```suggestion
# Show the dataframe index when emailing a CSV report
CSV_INDEX = True
```
Also, let's make this a boolean so it's less error-prone.
##########
superset/charts/post_processing.py:
##########
@@ -39,6 +39,11 @@
get_column_names,
get_metric_names,
)
+from superset import (
+ app
+)
+
+config = app.config
Review Comment:
It's better to use `current_app`:
```suggestion
from flask import current_app
config = current_app.config
```
##########
superset/charts/post_processing.py:
##########
@@ -368,7 +373,7 @@ def apply_post_process(
query["data"] = processed_df.to_dict()
elif query["result_format"] == ChartDataResultFormat.CSV:
buf = StringIO()
- processed_df.to_csv(buf)
+ processed_df.to_csv(buf, **config["CSV_INDEX"])
Review Comment:
See my comment below in `superset/config.py`.
```suggestion
processed_df.to_csv(buf, index=config["CSV_INDEX"])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "rohitpawar2811 (via GitHub)" <gi...@apache.org>.
rohitpawar2811 commented on code in PR #23155:
URL: https://github.com/apache/superset/pull/23155#discussion_r1491983162
##########
tests/integration_tests/fixtures/trends.csv:
##########
Review Comment:
"Hi! Here, I made some changes in one commit and then undid it in the next commit. However, the file is still shown here, but in my repository, there are no changes in this file.
Should I simply make a reset commit and perform a force push so that this file won't appear here?"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-1936531873
@betodealmeida @Antonio-RiveroMartnez looks like CI passed 🎉 Any bandwidth to revisit the requested changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "rohitpawar2811 (via GitHub)" <gi...@apache.org>.
rohitpawar2811 commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-2158649087
> Hey @rusackas, @rohitpawar2811, playing about with the API a bit, it seems that there is an Enum called [POST_PROCESSED](https://github.com/apache/superset/blob/5660f8e5542b78e098c42306633c182d9a631d63/superset/common/chart_data.py#L45) that is what is causing the additional index to be added. This is set [here](https://github.com/apache/superset/blob/5660f8e5542b78e098c42306633c182d9a631d63/superset/commands/report/execute.py#L162) in the report execution for the CSV datatype. If this is left blank, at least in the API, it returns the same data minus the index.
>
> We could add the config check to this point instead. WDYT?
@SkinnyPigeon
Yes, initially when I looked into it, I found the same: that post-processing was adding the index. However, by making the check there, we were disturbing a lot of other checks. That's why I moved on from that approach.
Actually there are some ingesters that are using csv/data download api, when I make changes in Post_Processing that ingesters check failed.
I think we have to go with Post_Processing but it needs a lot of refectoring. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "rohitpawar2811 (via GitHub)" <gi...@apache.org>.
rohitpawar2811 commented on code in PR #23155:
URL: https://github.com/apache/superset/pull/23155#discussion_r1491983162
##########
tests/integration_tests/fixtures/trends.csv:
##########
Review Comment:
Sure, here's the corrected version:
"Hi! Here, I made some changes in one commit and then undid it in the next commit. However, the file is still shown here, but in my repository, there are no changes in this file.
Should I simply make a reset commit and perform a force push so that this file won't appear here?"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "rohitpawar2811 (via GitHub)" <gi...@apache.org>.
rohitpawar2811 commented on code in PR #23155:
URL: https://github.com/apache/superset/pull/23155#discussion_r1492055274
##########
superset/commands/report/execute.py:
##########
@@ -254,6 +255,14 @@ def _get_csv_data(self) -> bytes:
try:
logger.info("Getting chart from %s as user %s", url, user.username)
csv_data = get_chart_csv_data(chart_url=url, auth_cookies=auth_cookies)
+ if csv_data:
+ buf = BytesIO()
+ temp_df = pd.read_csv(StringIO(csv_data.decode("utf-8")))
+ if temp_df.columns[0].strip() == "Unnamed: 0":
Review Comment:
>> Are we certain that no matter what the CVS file is, this is the value it gets with numbered columns?
Yes I am sure about it, and not able to find a better way to check that index column is present in csv or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Rohit-pawar902 commented on a diff in pull request #23155: fix :Extra column in csv while sending csv on email
Posted by "Rohit-pawar902 (via GitHub)" <gi...@apache.org>.
Rohit-pawar902 commented on code in PR #23155:
URL: https://github.com/apache/superset/pull/23155#discussion_r1119592497
##########
superset/config.py:
##########
@@ -748,6 +748,10 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
# note: index option should not be overridden
CSV_EXPORT = {"encoding": "utf-8"}
+#It Is used for enable/disable the index sequence for csv which came at email-time,
+#rearly someone want the index in csv so by-default it is false
+CSV_INDEX={"index":False}
+
Review Comment:
@betodealmeida Your all changes looks good and thanks for responce.
But According to this comment :
https://github.com/apache/superset/issues/22981#issuecomment-1440410419
I would thing we don't have to give config `opt true/false` , instead we can make this `processed_df.to_csv(buf, index=config["CSV_INDEX"]) ` to `processed_df.to_csv(buf, index=False)` Because it is really a bug.
what do you think ? I like to listen your thougts regarding to this.
@Antonio-RiveroMartnez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #23155: fix :Extra column in csv while sending csv on email
Posted by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>.
Antonio-RiveroMartnez commented on code in PR #23155:
URL: https://github.com/apache/superset/pull/23155#discussion_r1119917058
##########
superset/config.py:
##########
@@ -748,6 +748,10 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
# note: index option should not be overridden
CSV_EXPORT = {"encoding": "utf-8"}
+#It Is used for enable/disable the index sequence for csv which came at email-time,
+#rearly someone want the index in csv so by-default it is false
+CSV_INDEX={"index":False}
+
Review Comment:
Hey @rohitpawar2811 ! we could use `True/False` in case some users got used to the `row_number` already? as @betodealmeida said, we can change that in future releases along addressing the other problems listed in the issue. Let's add some tests for both cases tho. Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #23155: fix: Extra column in csv(or non-raw csv) get while sending on email
Posted by "betodealmeida (via GitHub)" <gi...@apache.org>.
betodealmeida commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-1492599194
> @betodealmeida I have updated the PR with suggested changes, could you please review it again?
Looks like some of the tests are failing, can you take a look at them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "betodealmeida (via GitHub)" <gi...@apache.org>.
betodealmeida commented on code in PR #23155:
URL: https://github.com/apache/superset/pull/23155#discussion_r1551826952
##########
superset/commands/report/execute.py:
##########
@@ -254,6 +255,14 @@ def _get_csv_data(self) -> bytes:
try:
logger.info("Getting chart from %s as user %s", url, user.username)
csv_data = get_chart_csv_data(chart_url=url, auth_cookies=auth_cookies)
+ if csv_data:
+ buf = BytesIO()
+ temp_df = pd.read_csv(StringIO(csv_data.decode("utf-8")))
+ if temp_df.columns[0].strip() == "Unnamed: 0":
Review Comment:
Is there a way to push the check for `CSV_INDEX` when we first create the CSV? It seems wasteful to create a CSV from a Dataframe with an index, convert the CSV back to a Dataframe, try to guess if it has an index, remove the first column, and convert it back to a CSV.
If we could simply drop the index from the Dataframe when first generating the CSV it would be more efficient and cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "rohitpawar2811 (via GitHub)" <gi...@apache.org>.
rohitpawar2811 closed pull request #23155: fix: Extra column in csv(or non-raw csv) get while sending on email
URL: https://github.com/apache/superset/pull/23155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rohitpawar2811 commented on pull request #23155: fix: Extra column in csv(or non-raw csv) get while sending on email
Posted by "rohitpawar2811 (via GitHub)" <gi...@apache.org>.
rohitpawar2811 commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-1733037343
@mike-fischer1 Actually, I think this fix would not work, as post-processing logic is used in other flows and is breaking things like data-import for maintaining the sequence/order of data through appending indexes.
There are other ways we can try:
1. We can disable the post_processing while emailing the data, but then the feature of sending ordered data, as we saw in Explore, will break. [Link to the API](https://superset-dev.hotwax.io/api/v1/chart/628/data/?format=json&type=post_processed&force=false)
2. Alternatively, we could drop the index after the data is retrieved from the API in the Email-Flow by checking that we have to return CSV data."
reports/execute.py
def _get_csv_data(self) -> bytes:
url = self._get_url(result_format=ChartDataResultFormat.CSV)
auth_cookies = machine_auth_provider_factory.instance.get_auth_cookies(
self._get_user()
)
if self._report_schedule.chart.query_context is None:
logger.warning("No query context found, taking a screenshot to generate it")
self._update_query_context()
try:
logger.info("Getting chart from %s", url)
csv_data = get_chart_csv_data(url, auth_cookies)
**###Here we apply check for CSV_INDEX enable disable and if disable then drop the csv index.**
except SoftTimeLimitExceeded as ex:
raise ReportScheduleCsvTimeout() from ex
except Exception as ex:
raise ReportScheduleCsvFailedError(
f"Failed generating csv {str(ex)}"
) from ex
if not csv_data:
raise ReportScheduleCsvFailedError()
return csv_data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-1922175761
> Or should we finish this PR?
I'm for it! @rohitpawar2811 are you able to follow up on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]
Posted by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>.
Antonio-RiveroMartnez commented on code in PR #23155:
URL: https://github.com/apache/superset/pull/23155#discussion_r1491270037
##########
tests/integration_tests/fixtures/trends.csv:
##########
Review Comment:
Shouldn't this file have some content? Shouldn't we have a test to cover the columns removal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org