You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "jeffkbkim (via GitHub)" <gi...@apache.org> on 2023/04/18 14:19:49 UTC

[GitHub] [kafka] jeffkbkim opened a new pull request, #13601: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

jeffkbkim opened a new pull request, #13601:
URL: https://github.com/apache/kafka/pull/13601

   …-915, Part-2) (#13526)
   
   This patch implemented the second part of KIP-915. It bumps the versions of the value records used by the group coordinator and the transaction coordinator to make them flexible versions. The new versions are not used when writing to the partitions but only when reading from the partitions. This allows downgrades from future versions that will include tagged fields.
   
   Reviewers: David Jacot <dj...@confluent.io>
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] jeffkbkim commented on pull request #13601: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

Posted by "jeffkbkim (via GitHub)" <gi...@apache.org>.
jeffkbkim commented on PR #13601:
URL: https://github.com/apache/kafka/pull/13601#issuecomment-1520572197

   this one as well
   ```
   [2023-04-24T15:00:18.297Z] FAILURE: Build failed with an exception.
   
   [2023-04-24T15:00:18.297Z] 
   
   [2023-04-24T15:00:18.297Z] * What went wrong:
   
   [2023-04-24T15:00:18.297Z] Execution failed for task ':streams:streams-scala:compileScala'.
   
   [2023-04-24T15:00:18.297Z] > Timeout waiting to lock zinc-1.3.5_2.13.6_17 compiler cache (/home/jenkins/.gradle/caches/7.2/zinc-1.3.5_2.13.6_17). It is currently in use by another Gradle instance.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] dajac commented on pull request #13601: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #13601:
URL: https://github.com/apache/kafka/pull/13601#issuecomment-1517708744

   @jeffkbkim Could you please rebase this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] dajac commented on pull request #13601: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #13601:
URL: https://github.com/apache/kafka/pull/13601#issuecomment-1521402202

   Failed tests are not related:
   ```
   Build / JDK 17 and Scala 2.13 / testClientDisconnectionUpdatesRequestMetrics() – kafka.network.SocketServerTest
   15s
   Build / JDK 17 and Scala 2.13 / shouldWriteLatestOffsetsToCheckpointOnShutdown[at_least_once] – org.apache.kafka.streams.integration.EosIntegrationTest
   43s
   Build / JDK 8 and Scala 2.12 / [1] Type=Raft, Name=testElectionResultOutput, Security=PLAINTEXT – kafka.admin.LeaderElectionCommandTest
   1m 12s
   Build / JDK 11 and Scala 2.13 / [1] Type=Raft, Name=testAllTopicPartition, Security=PLAINTEXT – kafka.admin.LeaderElectionCommandTest
   1m 14s
   Build / JDK 11 and Scala 2.13 / [1] Type=Raft, Name=testAllTopicPartition, Security=PLAINTEXT – kafka.admin.LeaderElectionCommandTest
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] dajac merged pull request #13601: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #13601:
URL: https://github.com/apache/kafka/pull/13601


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org