You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/10/15 05:43:25 UTC
[GitHub] [nifi] p-kimberley opened a new pull request, #6538: NIFI-10646 Handle failed GeoIP lookups in `GeoEnrichIPRecord` processor
p-kimberley opened a new pull request, #6538:
URL: https://github.com/apache/nifi/pull/6538
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-10646](https://issues.apache.org/jira/browse/NIFI-10646)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] p-kimberley commented on pull request #6538: NIFI-10646 Handle failed GeoIP lookups in `GeoEnrichIPRecord` processor
Posted by GitBox <gi...@apache.org>.
p-kimberley commented on PR #6538:
URL: https://github.com/apache/nifi/pull/6538#issuecomment-1285713526
Awaiting review by @mattyb149 into current handling of non-existent parent record nodes.
Will revisit this PR once that is completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6538: NIFI-10646 Handle failed GeoIP lookups in `GeoEnrichIPRecord` processor
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6538:
URL: https://github.com/apache/nifi/pull/6538#issuecomment-1380779992
Thanks for working on this @p-kimberley, closing for now based on comments about waiting for a review of current handling of parent record nodes. Feel free to reopen when that is addressed, or when you have evaluated additional changes to unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] p-kimberley commented on pull request #6538: NIFI-10646 Handle failed GeoIP lookups in `GeoEnrichIPRecord` processor
Posted by GitBox <gi...@apache.org>.
p-kimberley commented on PR #6538:
URL: https://github.com/apache/nifi/pull/6538#issuecomment-1279668358
Attempted `mvn -Pcontrib-check clean install`, however current `main` branch is failing with errors about unapproved licenses:
```
NIFI-10646 Handle failed GeoIP lookups in `GeoEnrichIPRecord` processor
```
License failures are related to `nifi-commons/nifi-vault-utils` module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on pull request #6538: NIFI-10646 Handle failed GeoIP lookups in `GeoEnrichIPRecord` processor
Posted by GitBox <gi...@apache.org>.
MikeThomsen commented on PR #6538:
URL: https://github.com/apache/nifi/pull/6538#issuecomment-1285310061
The GeoIP enrichment unit tests are what's failing now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6538: NIFI-10646 Handle failed GeoIP lookups in `GeoEnrichIPRecord` processor
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #6538: NIFI-10646 Handle failed GeoIP lookups in `GeoEnrichIPRecord` processor
URL: https://github.com/apache/nifi/pull/6538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org