You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2015/03/11 19:43:10 UTC
Review Request 31951: Added test for long lived executors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31951/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Kapil Arya, and switched to 'mcypark'.
Bugs: MESOS-2463
https://issues.apache.org/jira/browse/MESOS-2463
Repository: mesos
Description
-------
Environment decorators broke long lived executors during master fail over (MESOS-2463).
This test verifies the fix suggested in r31889.
Diffs
-----
src/tests/master_tests.cpp acf7050ce69a196ac74627d607b4664060fa1117
Diff: https://reviews.apache.org/r/31951/diff/
Testing
-------
make check with and without r31889. (Breaks before with TASK_ERROR similar to MESOS-2463):
------------------------------------------------------------
Existing ExecutorInfo:
executor_id {
value: "default"
}
command {
environment {
}
value: "exit 1"
}
framework_id {
value: "20150311-114156-3758096394-50894-29122-0000"
}
------------------------------------------------------------
Task's ExecutorInfo:
executor_id {
value: "default"
}
command {
value: "exit 1"
}
framework_id {
value: "20150311-114156-3758096394-50894-29122-0000"
}
------------------------------------------------------------
Thanks,
Niklas Nielsen
Re: Review Request 31951: Added test for long lived executors.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31951/#review76104
-----------------------------------------------------------
Bad patch!
Reviews applied: [31889]
Failed command: ./support/apply-review.sh -n -r 31889
Error:
2015-03-11 18:51:59 URL:https://reviews.apache.org/r/31889/diff/raw/ [12515/12515] -> "31889.patch" [1]
error: patch failed: src/examples/test_hook_module.cpp:101
error: src/examples/test_hook_module.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On March 11, 2015, 6:43 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31951/
> -----------------------------------------------------------
>
> (Updated March 11, 2015, 6:43 p.m.)
>
>
> Review request for mesos, Ben Mahler, Kapil Arya, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2463
> https://issues.apache.org/jira/browse/MESOS-2463
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Environment decorators broke long lived executors during master fail over (MESOS-2463).
> This test verifies the fix suggested in r31889.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp acf7050ce69a196ac74627d607b4664060fa1117
>
> Diff: https://reviews.apache.org/r/31951/diff/
>
>
> Testing
> -------
>
> make check with and without r31889. (Breaks before with TASK_ERROR similar to MESOS-2463):
>
> ------------------------------------------------------------
> Existing ExecutorInfo:
> executor_id {
> value: "default"
> }
> command {
> environment {
> }
> value: "exit 1"
> }
> framework_id {
> value: "20150311-114156-3758096394-50894-29122-0000"
> }
>
> ------------------------------------------------------------
> Task's ExecutorInfo:
> executor_id {
> value: "default"
> }
> command {
> value: "exit 1"
> }
> framework_id {
> value: "20150311-114156-3758096394-50894-29122-0000"
> }
>
> ------------------------------------------------------------
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 31951: Added test for long lived executors.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31951/#review76140
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31889, 31951]
All tests passed.
- Mesos ReviewBot
On March 11, 2015, 9:17 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31951/
> -----------------------------------------------------------
>
> (Updated March 11, 2015, 9:17 p.m.)
>
>
> Review request for mesos, Ben Mahler, Kapil Arya, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2463
> https://issues.apache.org/jira/browse/MESOS-2463
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Environment decorators broke long lived executors during master fail over (MESOS-2463).
> This test verifies the fix suggested in r31889.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp acf7050ce69a196ac74627d607b4664060fa1117
>
> Diff: https://reviews.apache.org/r/31951/diff/
>
>
> Testing
> -------
>
> make check with and without r31889. (Breaks before with TASK_ERROR similar to MESOS-2463):
>
> ------------------------------------------------------------
> Existing ExecutorInfo:
> executor_id {
> value: "default"
> }
> command {
> environment {
> }
> value: "exit 1"
> }
> framework_id {
> value: "20150311-114156-3758096394-50894-29122-0000"
> }
>
> ------------------------------------------------------------
> Task's ExecutorInfo:
> executor_id {
> value: "default"
> }
> command {
> value: "exit 1"
> }
> framework_id {
> value: "20150311-114156-3758096394-50894-29122-0000"
> }
>
> ------------------------------------------------------------
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 31951: Added test for long lived executors.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31951/
-----------------------------------------------------------
(Updated March 11, 2015, 2:17 p.m.)
Review request for mesos, Ben Mahler, Kapil Arya, and switched to 'mcypark'.
Changes
-------
Addressed Vinod's comments
Bugs: MESOS-2463
https://issues.apache.org/jira/browse/MESOS-2463
Repository: mesos
Description
-------
Environment decorators broke long lived executors during master fail over (MESOS-2463).
This test verifies the fix suggested in r31889.
Diffs (updated)
-----
src/tests/master_tests.cpp acf7050ce69a196ac74627d607b4664060fa1117
Diff: https://reviews.apache.org/r/31951/diff/
Testing
-------
make check with and without r31889. (Breaks before with TASK_ERROR similar to MESOS-2463):
------------------------------------------------------------
Existing ExecutorInfo:
executor_id {
value: "default"
}
command {
environment {
}
value: "exit 1"
}
framework_id {
value: "20150311-114156-3758096394-50894-29122-0000"
}
------------------------------------------------------------
Task's ExecutorInfo:
executor_id {
value: "default"
}
command {
value: "exit 1"
}
framework_id {
value: "20150311-114156-3758096394-50894-29122-0000"
}
------------------------------------------------------------
Thanks,
Niklas Nielsen
Re: Review Request 31951: Added test for long lived executors.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31951/#review76108
-----------------------------------------------------------
Ship it!
src/tests/master_tests.cpp
<https://reviews.apache.org/r/31951/#comment123526>
s/work/works/
src/tests/master_tests.cpp
<https://reviews.apache.org/r/31951/#comment123527>
s/launch/launches/
s/restart/restarts/
s/launch/launches/
src/tests/master_tests.cpp
<https://reviews.apache.org/r/31951/#comment123521>
s/LongLivedExecutor/MasterFailoverLongLivedExecutor/
src/tests/master_tests.cpp
<https://reviews.apache.org/r/31951/#comment123523>
kill this? you already have an expectation below with a comment.
src/tests/master_tests.cpp
<https://reviews.apache.org/r/31951/#comment123525>
move this to just above detector.appoint()
- Vinod Kone
On March 11, 2015, 6:43 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31951/
> -----------------------------------------------------------
>
> (Updated March 11, 2015, 6:43 p.m.)
>
>
> Review request for mesos, Ben Mahler, Kapil Arya, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2463
> https://issues.apache.org/jira/browse/MESOS-2463
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Environment decorators broke long lived executors during master fail over (MESOS-2463).
> This test verifies the fix suggested in r31889.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp acf7050ce69a196ac74627d607b4664060fa1117
>
> Diff: https://reviews.apache.org/r/31951/diff/
>
>
> Testing
> -------
>
> make check with and without r31889. (Breaks before with TASK_ERROR similar to MESOS-2463):
>
> ------------------------------------------------------------
> Existing ExecutorInfo:
> executor_id {
> value: "default"
> }
> command {
> environment {
> }
> value: "exit 1"
> }
> framework_id {
> value: "20150311-114156-3758096394-50894-29122-0000"
> }
>
> ------------------------------------------------------------
> Task's ExecutorInfo:
> executor_id {
> value: "default"
> }
> command {
> value: "exit 1"
> }
> framework_id {
> value: "20150311-114156-3758096394-50894-29122-0000"
> }
>
> ------------------------------------------------------------
>
>
> Thanks,
>
> Niklas Nielsen
>
>