You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/16 11:55:58 UTC
[GitHub] [flink] gaoyunhaii commented on a change in pull request #14390: [hotfix] Various hotfixes from a static code analysis
gaoyunhaii commented on a change in pull request #14390:
URL: https://github.com/apache/flink/pull/14390#discussion_r544239116
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyMessageClientDecoderDelegateTest.java
##########
@@ -162,8 +162,9 @@ private void testNettyMessageClientDecoding(
try {
List<BufferResponse> messages = createMessageList(
hasEmptyBuffer,
- hasBufferForReleasedChannel,
- hasBufferForRemovedChannel);
+ hasBufferForRemovedChannel,
Review comment:
Yes, this is indeed not right and need fix. Very thanks for the fix! And if possible I think it might be better to swap the parameter orders of `createMessageList` instead to keep all the methods have the same parameter order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org