You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by liming01 <gi...@git.apache.org> on 2016/02/01 06:33:18 UTC
[GitHub] incubator-hawq pull request: HAWQ-376. Fixed QE core dump at HdfsC...
GitHub user liming01 opened a pull request:
https://github.com/apache/incubator-hawq/pull/312
HAWQ-376. Fixed QE core dump at HdfsCloseFile() when run stress test …
…with COPY
The root cause of this defect is:
When the master got some error, it will send signal SIGABRT to all segments and then rollback all works done by all segments. If the segment node haven't finished processing SIGABRT before the master finishing rollback, all segfile created at this segment is deleted at master node in fact. So it will report warning to close/delete that hdfs file. We should clean up hdfs file cache before calling HdfsCloseFile(), so that we will skip second call of HdfsCloseFile() at ShutdownPostgres().
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liming01/incubator-hawq mli/copy_crash_at_HdfsCloseFile
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/312.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #312
----
commit 14e479da85d03edaeed7f3a24ba535611fa13b1e
Author: Ming LI <ml...@pivotal.io>
Date: 2016-02-01T05:24:40Z
HAWQ-376. Fixed QE core dump at HdfsCloseFile() when run stress test with COPY
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-376. Fixed QE core dump at HdfsC...
Posted by wangzw <gi...@git.apache.org>.
Github user wangzw commented on the pull request:
https://github.com/apache/incubator-hawq/pull/312#issuecomment-178322566
looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-376. Fixed QE core dump at HdfsC...
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/312
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-376. Fixed QE core dump at HdfsC...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/312#discussion_r51515926
--- Diff: src/backend/storage/file/fd.c ---
@@ -632,33 +632,54 @@ LruDelete(File file)
if (vfdP->seekPos == INT64CONST(-1))
elog(ERROR, "could not get the current position of file \"%s\": %m", vfdP->fileName);
- /* close the file */
- if (IsLocalPath(VfdCache[file].fileName))
- {
- if (close(vfdP->fd))
- elog(ERROR, "could not close file \"%s\": %m", vfdP->fileName);
- }
+ // Need to firstly remove file description from VfdCache before closing file,
--- End diff --
For multiple line comment, use
/**
* xxx
*/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-376. Fixed QE core dump at HdfsC...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/312#issuecomment-178328042
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---