[GitHub] [daffodil] jadams-tresys opened a new pull request, #987: Evaluate assert/discriminator expressions after groupContent: WIP

["jadams-tresys (via GitHub)" <gi...@apache.org>]

jadams-tresys opened a new pull request, #987:
URL: https://github.com/apache/daffodil/pull/987

   According to 9.5 of the DFDL spec assert and discriminators with expressions should be processed after the content of their enclosing sequence, group, or choice. Before these expressions were always being processed before the content.
   
   This commit also moves the setVariable expression evaluaiton to the correct place, which is before the enclosing group.
   
   DAFFODIL-1971, DAFFODIL-1590


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil] jadams-tresys commented on pull request #987: Evaluate assert/discriminator expressions after groupContent: WIP

["jadams-tresys (via GitHub)" <gi...@apache.org>]

jadams-tresys commented on PR #987:
URL: https://github.com/apache/daffodil/pull/987#issuecomment-1466818490

   This is primarily WIP as it needs more test coverage and I have been informed that I need to hold off on working on this for a little while.
   
   It is fully functional, just needs more tests for edge cases surrounding  evaluating expressions after the content of sequences, groups, and choices.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org