You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/04 01:12:55 UTC

[GitHub] [arrow] bkietz commented on a change in pull request #7896: ARROW-9609: [C++][Dataset] CsvFileFormat reads all virtual columns as null

bkietz commented on a change in pull request #7896:
URL: https://github.com/apache/arrow/pull/7896#discussion_r464742390



##########
File path: cpp/src/arrow/dataset/file_csv.cc
##########
@@ -39,49 +41,92 @@ namespace dataset {
 using internal::checked_cast;
 using internal::checked_pointer_cast;
 
+Result<std::unordered_set<std::string>> GetColumnNames(

Review comment:
       I wrote this as a separate function in part so that it would be easy to extract as a public function if we wanted that. I'd like to leave that for a follow up, though




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org