You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/03/05 17:23:00 UTC
[jira] [Work logged] (KNOX-2263) Docker - make sure not to put
anything except version in the tag
[ https://issues.apache.org/jira/browse/KNOX-2263?focusedWorklogId=398522&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398522 ]
ASF GitHub Bot logged work on KNOX-2263:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/20 17:22
Start Date: 05/Mar/20 17:22
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #279: KNOX-2263 - Docker - make sure not to put anything except version in the tag
URL: https://github.com/apache/knox/pull/279
## What changes were proposed in this pull request?
Make sure that only the version is in the docker image tag.
## How was this patch tested?
* `mvn -T.75C package -Ppackage,release,docker -Dshellcheck -DskipTests`
* Checked created image
```
docker images | grep -F apache/
apache/knox-demo-ldap 1.4.0-SNAPSHOT 714adc69aef4 17 seconds ago 533MB
apache/knox-gateway 1.4.0-SNAPSHOT 1e6f961b86f0 34 seconds ago 533MB
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 398522)
Remaining Estimate: 0h
Time Spent: 10m
> Docker - make sure not to put anything except version in the tag
> ----------------------------------------------------------------
>
> Key: KNOX-2263
> URL: https://issues.apache.org/jira/browse/KNOX-2263
> Project: Apache Knox
> Issue Type: Sub-task
> Components: docker
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the way the Docker images are created they are:
> apache/knox:gateway-VERSION
> apache/knox:ldap-VERSION
> This shouldn't be done since it should be:
> apache/knox-gateway:VERSION
> apache/knox-demo-ldap:VERSION
> This would be cleaner from Docker perspective and not put anything else in tags.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)