You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/08 06:48:13 UTC
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33934: [SPARK-36691][PYSPARK] PythonRunner failed should pass error message to ApplicationMaster too
AngersZhuuuu commented on a change in pull request #33934:
URL: https://github.com/apache/spark/pull/33934#discussion_r704101357
##########
File path: core/src/main/scala/org/apache/spark/deploy/PythonRunner.scala
##########
@@ -92,15 +92,19 @@ object PythonRunner {
// see https://github.com/numpy/numpy/issues/10455
sparkConf.getOption("spark.driver.cores").foreach(env.put("OMP_NUM_THREADS", _))
}
- builder.redirectErrorStream(true) // Ugly but needed for stdout and stderr to synchronize
try {
val process = builder.start()
+ val stderrBuffer = new CircularBuffer(2048)
+ new RedirectThread(
+ process.getErrorStream,
+ stderrBuffer,
+ "Thread-ScriptTransformation-STDERR-Consumer").start()
Review comment:
> Why is it ScriptTransform?
Updated to PythonRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org