You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by vesense <gi...@git.apache.org> on 2015/07/16 04:29:50 UTC
[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/635
[STORM-643] KafkaUtils repeatedly fetches messages whose offset is out of range
STORM-643 fixing for 0.9.x-branch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/storm patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/635.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #635
----
commit 9221dba1eee59686ec6a1bcfd93d4ce542b071e9
Author: Xin Wang <be...@163.com>
Date: 2015-07-16T02:06:28Z
Fix incorrect WARN log
commit a6557a565429b2e12fc0659c6484fc50f90b5cd5
Author: Xin Wang <be...@163.com>
Date: 2015-07-16T02:19:41Z
Remove outdated failed offsets
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/635#issuecomment-122479965
@HeartSaVioR
I have created a new PR(https://github.com/apache/storm/pull/642) based on master branch. Could you take a look? Thx.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/635
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/635#issuecomment-122468927
@vesense Though I don't know about storm-kafka deeply, seems like ExponentialBackoffMsgRetryManager doesn't care about it. It just delays retrying failed tuples, and doesn't remove failed tuples with invalid offset.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/635#issuecomment-122462058
+1. I'll merge it.
Please note that we're considering only 0.9.x now, so we should try to reproduce and fix from 0.10.x and master later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/635#issuecomment-122479359
@HeartSaVioR Yeah, you are right. We can reproduce the issue with 0.10.x branch too. And I will make a new PR based on master branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/635#issuecomment-122467741
Thanks for reminding. Yes, I'm working on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---