You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/05 07:38:56 UTC
[GitHub] [flink] Aitozi opened a new pull request #17414: [FLINK-24451]Replace the scattered objects with encapsulated LeaderIn…
Aitozi opened a new pull request #17414:
URL: https://github.com/apache/flink/pull/17414
…formation in DefaultLeaderElectionService
## What is the purpose of the change
This PR is a minor code refactor in `DefaultLeaderElectionService`
## Verifying this change
This change is a trivial rework without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17414: [FLINK-24451][HA]Replace the scattered objects with encapsulated LeaderIn…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17414:
URL: https://github.com/apache/flink/pull/17414#issuecomment-934166633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f555d437c6a4a64ab4c0c0a927b1aa1dd36c6eb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24768",
"triggerID" : "3f555d437c6a4a64ab4c0c0a927b1aa1dd36c6eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f555d437c6a4a64ab4c0c0a927b1aa1dd36c6eb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24768)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17414: [FLINK-24451][HA]Replace the scattered objects with encapsulated LeaderIn…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17414:
URL: https://github.com/apache/flink/pull/17414#issuecomment-934166633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f555d437c6a4a64ab4c0c0a927b1aa1dd36c6eb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24768",
"triggerID" : "3f555d437c6a4a64ab4c0c0a927b1aa1dd36c6eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f555d437c6a4a64ab4c0c0a927b1aa1dd36c6eb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24768)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #17414: [FLINK-24451][HA]Replace the scattered objects with encapsulated LeaderIn…
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #17414:
URL: https://github.com/apache/flink/pull/17414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17414: [FLINK-24451][HA]Replace the scattered objects with encapsulated LeaderIn…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17414:
URL: https://github.com/apache/flink/pull/17414#issuecomment-934166633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f555d437c6a4a64ab4c0c0a927b1aa1dd36c6eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24768",
"triggerID" : "3f555d437c6a4a64ab4c0c0a927b1aa1dd36c6eb",
"triggerType" : "PUSH"
}, {
"hash" : "1686d0a0086c78c236e0acff199807d6755848fc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24840",
"triggerID" : "1686d0a0086c78c236e0acff199807d6755848fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1686d0a0086c78c236e0acff199807d6755848fc Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24840)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17414: [FLINK-24451]Replace the scattered objects with encapsulated LeaderIn…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17414:
URL: https://github.com/apache/flink/pull/17414#issuecomment-934151567
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 219797caaa859e6a740385168a470c12322ea358 (Tue Oct 05 07:43:16 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24451).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #17414: [FLINK-24451][HA]Replace the scattered objects with encapsulated LeaderIn…
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #17414:
URL: https://github.com/apache/flink/pull/17414#discussion_r724319224
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java
##########
@@ -263,13 +257,11 @@ public void onLeaderInformationChange(LeaderInformation leaderInformation) {
LOG.trace(
"Leader node changed while {} is the leader with session ID {}. New leader information {}.",
leaderContender.getDescription(),
- confirmedLeaderSessionID,
+ confirmedLeaderInformation.getLeaderSessionID(),
leaderInformation);
}
- if (confirmedLeaderSessionID != null) {
- final LeaderInformation confirmedLeaderInfo =
- LeaderInformation.known(
- confirmedLeaderSessionID, confirmedLeaderAddress);
+ if (confirmedLeaderInformation.getLeaderSessionID() != null) {
Review comment:
```suggestion
if (!confirmedLeaderInformation.isEmpty()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17414: [FLINK-24451][HA]Replace the scattered objects with encapsulated LeaderIn…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17414:
URL: https://github.com/apache/flink/pull/17414#issuecomment-934166633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f555d437c6a4a64ab4c0c0a927b1aa1dd36c6eb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24768",
"triggerID" : "3f555d437c6a4a64ab4c0c0a927b1aa1dd36c6eb",
"triggerType" : "PUSH"
}, {
"hash" : "1686d0a0086c78c236e0acff199807d6755848fc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1686d0a0086c78c236e0acff199807d6755848fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f555d437c6a4a64ab4c0c0a927b1aa1dd36c6eb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24768)
* 1686d0a0086c78c236e0acff199807d6755848fc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #17414: [FLINK-24451][HA]Replace the scattered objects with encapsulated LeaderIn…
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #17414:
URL: https://github.com/apache/flink/pull/17414#discussion_r724319224
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java
##########
@@ -263,13 +257,11 @@ public void onLeaderInformationChange(LeaderInformation leaderInformation) {
LOG.trace(
"Leader node changed while {} is the leader with session ID {}. New leader information {}.",
leaderContender.getDescription(),
- confirmedLeaderSessionID,
+ confirmedLeaderInformation.getLeaderSessionID(),
leaderInformation);
}
- if (confirmedLeaderSessionID != null) {
- final LeaderInformation confirmedLeaderInfo =
- LeaderInformation.known(
- confirmedLeaderSessionID, confirmedLeaderAddress);
+ if (confirmedLeaderInformation.getLeaderSessionID() != null) {
Review comment:
```suggestion
if (!confirmedLeaderInformation.isEmpty()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Aitozi commented on pull request #17414: [FLINK-24451]Replace the scattered objects with encapsulated LeaderIn…
Posted by GitBox <gi...@apache.org>.
Aitozi commented on pull request #17414:
URL: https://github.com/apache/flink/pull/17414#issuecomment-934151304
Please help review when you are free 🙂 @tillrohrmann
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17414: [FLINK-24451][HA]Replace the scattered objects with encapsulated LeaderIn…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17414:
URL: https://github.com/apache/flink/pull/17414#issuecomment-934166633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f555d437c6a4a64ab4c0c0a927b1aa1dd36c6eb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24768",
"triggerID" : "3f555d437c6a4a64ab4c0c0a927b1aa1dd36c6eb",
"triggerType" : "PUSH"
}, {
"hash" : "1686d0a0086c78c236e0acff199807d6755848fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24840",
"triggerID" : "1686d0a0086c78c236e0acff199807d6755848fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f555d437c6a4a64ab4c0c0a927b1aa1dd36c6eb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24768)
* 1686d0a0086c78c236e0acff199807d6755848fc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24840)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17414: [FLINK-24451][HA]Replace the scattered objects with encapsulated LeaderIn…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17414:
URL: https://github.com/apache/flink/pull/17414#issuecomment-934166633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f555d437c6a4a64ab4c0c0a927b1aa1dd36c6eb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3f555d437c6a4a64ab4c0c0a927b1aa1dd36c6eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f555d437c6a4a64ab4c0c0a927b1aa1dd36c6eb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org