You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/12/19 03:26:05 UTC
[GitHub] [rocketmq] jamesxuhaozhe opened a new issue #1665: More Unit Test
for Validators class
jamesxuhaozhe opened a new issue #1665: More Unit Test for Validators class
URL: https://github.com/apache/rocketmq/issues/1665
1. Validators class in the client package seems needing more UT
2. In Validators class, 255 as a charactor limit is hard coded in the error message instead of using CHARACTER_MAX_LENGTH
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] jamesxuhaozhe commented on issue #1665: More Unit Test
for Validators class
Posted by GitBox <gi...@apache.org>.
jamesxuhaozhe commented on issue #1665: More Unit Test for Validators class
URL: https://github.com/apache/rocketmq/issues/1665#issuecomment-605785357
is there anyway this pr can be merged ? because this is really adding unit test, i don't know how it can lower the test coverage..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services