[GitHub] [incubator-netbeans] jlahoda commented on a change in pull request #1107: Starting to eliminate remaining usages of old javadoc API and impleme…

[GitBox <gi...@apache.org>]

jlahoda commented on a change in pull request #1107: Starting to eliminate remaining usages of old javadoc API and impleme…
URL: https://github.com/apache/incubator-netbeans/pull/1107#discussion_r271892105
 
 

 ##########
 File path: nbbuild/templates/projectized.xml
 ##########
 @@ -112,6 +112,9 @@ If you are sure you want to build with JDK 9+ anyway, use: -Dpermit.jdk9.builds=
                       compilecp="test.qa-functional.compile.cp"
                       compiledep="test.qa-functional.testdep"/>
         </parseprojectxml>
+        <condition property="requires.nb.javac" value="true">
+            <contains string="${module.classpath}" substring="/org-netbeans-libs-javacapi.jar" />
+        </condition>
 
 Review comment:
   The intent here is to make requires.nb.javac inferred automatically (for nb.org modules only, I think, as projectized.xml contains enhancements for nb.org modules). If a module depends on javacapi, then it should get the proper version of the API automatically (by setting the property). Not strictly necessary for this version of this patch, but feels generally useful and was needed during development.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists