You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2023/05/20 13:27:43 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request, #6401: run tests with avro enabled when verifying a release candidate
andygrove opened a new pull request, #6401:
URL: https://github.com/apache/arrow-datafusion/pull/6401
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Related to https://github.com/apache/arrow-datafusion/issues/6399 but does not close the issue
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
I would like the release verification script to work so that I can create the next release
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Enable `avro` feature when running tests in the release verification script
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
Yes, manually
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #6401: run tests with avro enabled when verifying a release candidate
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #6401:
URL: https://github.com/apache/arrow-datafusion/pull/6401#discussion_r1200794071
##########
dev/release/verify-release-candidate.sh:
##########
@@ -126,7 +126,7 @@ test_source_distribution() {
git clone https://github.com/apache/parquet-testing.git parquet-testing
cargo build
- cargo test --all
+ cargo test --all --features=avro
Review Comment:
Double checked, tests running fine. sqllogictests running ok as well.
##########
dev/release/verify-release-candidate.sh:
##########
@@ -126,7 +126,7 @@ test_source_distribution() {
git clone https://github.com/apache/parquet-testing.git parquet-testing
cargo build
- cargo test --all
+ cargo test --all --features=avro
Review Comment:
👍 Double checked, tests running fine. sqllogictests running ok as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6401: run tests with avro enabled when verifying a release candidate
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6401:
URL: https://github.com/apache/arrow-datafusion/pull/6401#issuecomment-1556157178
I can also look into fixing the sqllogictest so that it only runs when avro is enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6401: run tests with avro enabled when verifying a release candidate
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6401:
URL: https://github.com/apache/arrow-datafusion/pull/6401#issuecomment-1559476951
Thanks @andygrove @izveigor and @comphead !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6401: run tests with avro enabled when verifying a release candidate
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6401:
URL: https://github.com/apache/arrow-datafusion/pull/6401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org