[GitHub] [spark] HyukjinKwon edited a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.

[GitBox <gi...@apache.org>]

HyukjinKwon edited a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704629549


   I personally tend to agree with what you listed up. However, one concern is that it doesn't work well out of the box when the criteria becomes verbose especially for new contributors given my experience - the same criteria is interpreted differently often. So I ended up with focusing on simplifying it unless it's required.
   
   Also, one more thing is that I would like to be explicit what we expose and hide as APIs. Something has been internal so it was changed but users ended up with complaining - this happens not very often but not so rarely. I would like to avoid this kind of cost.
   
   To sum up, we can keep `python/join.pyi` and `python/rddsampler.pyi` but let's make sure these are special cases. Do the removal of both, for example, cause many ignores? If that's the case, we can keep probably with leaving some comments. Otherwise, let's remove both and start with the simpler set ..


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org