You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/02/19 23:08:45 UTC
[kudu-CR] Support decimal columns in load generation tool
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9362
Change subject: Support decimal columns in load generation tool
......................................................................
Support decimal columns in load generation tool
Change-Id: I8f9441ab3483775e74f5fdedfff309bdcbc8ab17
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_perf.cc
2 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/9362/1
--
To view, visit http://gerrit.cloudera.org:8080/9362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f9441ab3483775e74f5fdedfff309bdcbc8ab17
Gerrit-Change-Number: 9362
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
[kudu-CR] Support decimal columns in load generation tool
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9362 )
Change subject: Support decimal columns in load generation tool
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9362/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/9362/1/src/kudu/tools/kudu-tool-test.cc@1345
PS1, Line 1345: DECIMAL32
DECIMAL64 ?
http://gerrit.cloudera.org:8080/#/c/9362/1/src/kudu/tools/kudu-tool-test.cc@1348
PS1, Line 1348: DECIMAL32
DECIMAL128 ?
--
To view, visit http://gerrit.cloudera.org:8080/9362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f9441ab3483775e74f5fdedfff309bdcbc8ab17
Gerrit-Change-Number: 9362
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 20 Feb 2018 18:05:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] Support decimal columns in load generation tool
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9362 )
Change subject: Support decimal columns in load generation tool
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9362/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/9362/1/src/kudu/tools/kudu-tool-test.cc@1345
PS1, Line 1345: DECIMAL32
> DECIMAL64 ?
Done
http://gerrit.cloudera.org:8080/#/c/9362/1/src/kudu/tools/kudu-tool-test.cc@1348
PS1, Line 1348: DECIMAL32
> DECIMAL128 ?
Done
--
To view, visit http://gerrit.cloudera.org:8080/9362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f9441ab3483775e74f5fdedfff309bdcbc8ab17
Gerrit-Change-Number: 9362
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 20 Feb 2018 18:12:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] Support decimal columns in load generation tool
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9362 )
Change subject: Support decimal columns in load generation tool
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f9441ab3483775e74f5fdedfff309bdcbc8ab17
Gerrit-Change-Number: 9362
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 20 Feb 2018 18:17:38 +0000
Gerrit-HasComments: No
[kudu-CR] Support decimal columns in load generation tool
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9362 )
Change subject: Support decimal columns in load generation tool
......................................................................
Support decimal columns in load generation tool
Change-Id: I8f9441ab3483775e74f5fdedfff309bdcbc8ab17
Reviewed-on: http://gerrit.cloudera.org:8080/9362
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_perf.cc
2 files changed, 23 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f9441ab3483775e74f5fdedfff309bdcbc8ab17
Gerrit-Change-Number: 9362
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Support decimal columns in load generation tool
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9362
to look at the new patch set (#2).
Change subject: Support decimal columns in load generation tool
......................................................................
Support decimal columns in load generation tool
Change-Id: I8f9441ab3483775e74f5fdedfff309bdcbc8ab17
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_perf.cc
2 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/9362/2
--
To view, visit http://gerrit.cloudera.org:8080/9362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f9441ab3483775e74f5fdedfff309bdcbc8ab17
Gerrit-Change-Number: 9362
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins