[GitHub] [iceberg] jackye1995 commented on pull request #2510: Core: Add content field to ManifestTable Schema.

[GitBox <gi...@apache.org>]

jackye1995 commented on pull request #2510:
URL: https://github.com/apache/iceberg/pull/2510#issuecomment-827785132


   Sorry for the back and forth, now I think about it, the files table has this in schema:
   
   ```java
   optional(134, "content", IntegerType.get(), "Contents of the file: 0=data, 1=position deletes, 2=equality deletes");
   ```
   
   So it would make more sense to use int also for manifest, but we should add a doc similar to the files table like:
   
   ```java
   optional(14, "content", IntegerType.get(), "Contents of the manifest: 0=data, 1=deletes");
   ```
   
   so that people know what the values mean.
   
   Apart from that, I don't have any further comments, thanks for the work.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org