You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Georg Buschbeck <gb...@thomas-daily.de> on 2012/09/21 11:28:23 UTC
JavaScriptReference
hi
while trying to integrate gmaps3 in our webapp i had issues with the
wicketstuff-gmap3 stuff ( - we need a client-id for our request) ...
so i have:
public static final String GMAP_API_URL =
"%s://maps.google.com/maps/api/js?v=3&sensor=%s&client-id=%s";
response.render(JavaScriptHeaderItem.forUrl(String.format(GMAP_API_URL,
schema, sensor, clientid)));
the rendered result of this is:
<script type="text/javascript"
src="http://maps.google.com/maps/api/js?v=3&sensor=false&client-id=...."></script>
so the requestparameters are encoded
which is happening in the JavaScriptUtils Helper:
public static void writeJavaScriptUrl(final Response response, final
CharSequence url, final String id, boolean defer, String charset)
{
response.write("<script type=\"text/javascript\" ");
if (id != null)
{
response.write("id=\"" + Strings.escapeMarkup(id) + "\" ");
}
if (defer)
{
response.write("defer=\"defer\" ");
}
if (charset != null)
{
response.write("charset=\"" + Strings.escapeMarkup(charset) + "\" ");
}
response.write("src=\"");
response.write(Strings.escapeMarkup(url));
response.write("\"></script>");
response.write("\n");
}
but ... is this right to escape the url?
when i open the above mentioned script, google tells me i have no
parameter "sensor" ... which i can understand as ther is only a
parameter amp ...
Any ideas?
Thanks,
Georg
--
Georg Buschbeck
Information Technology
THOMAS DAILY GmbH
Adlerstraße 19
79098 Freiburg
Deutschland
T + 49 761 3 85 59 502
F + 49 761 3 85 59 550
E gb@thomas-daily.de
www.thomas-daily.de
Geschäftsführer/Managing Directors:
Wendy Thomas, Susanne Larbig
Handelsregister Freiburg i.Br., HRB 3947
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: JavaScriptReference
Posted by Martin Grigorov <mg...@apache.org>.
Thank you!
On Fri, Sep 21, 2012 at 2:00 PM, Georg Buschbeck <gb...@thomas-daily.de> wrote:
> okay, i filed a bug report ...
>
>
>
>
> On 09/21/2012 11:59 AM, Martin Grigorov wrote:
>>
>> Hi,
>>
>> Looks like a bug.
>>
>> On Fri, Sep 21, 2012 at 12:28 PM, Georg Buschbeck <gb...@thomas-daily.de>
>> wrote:
>>>
>>> hi
>>>
>>> while trying to integrate gmaps3 in our webapp i had issues with the
>>> wicketstuff-gmap3 stuff ( - we need a client-id for our request) ...
>>>
>>> so i have:
>>>
>>> public static final String GMAP_API_URL =
>>> "%s://maps.google.com/maps/api/js?v=3&sensor=%s&client-id=%s";
>>>
>>> response.render(JavaScriptHeaderItem.forUrl(String.format(GMAP_API_URL,
>>> schema, sensor, clientid)));
>>>
>>>
>>> the rendered result of this is:
>>> <script type="text/javascript"
>>>
>>> src="http://maps.google.com/maps/api/js?v=3&sensor=false&client-id=...."></script>
>>>
>>>
>>> so the requestparameters are encoded
>>>
>>> which is happening in the JavaScriptUtils Helper:
>>> public static void writeJavaScriptUrl(final Response response, final
>>> CharSequence url, final String id, boolean defer, String charset)
>>> {
>>> response.write("<script type=\"text/javascript\" ");
>>> if (id != null)
>>> {
>>> response.write("id=\"" +
>>> Strings.escapeMarkup(id) +
>>> "\" ");
>>> }
>>> if (defer)
>>> {
>>> response.write("defer=\"defer\" ");
>>> }
>>> if (charset != null)
>>> {
>>> response.write("charset=\"" +
>>> Strings.escapeMarkup(charset) + "\" ");
>>> }
>>> response.write("src=\"");
>>> response.write(Strings.escapeMarkup(url));
>>> response.write("\"></script>");
>>> response.write("\n");
>>> }
>>>
>>> but ... is this right to escape the url?
>>>
>>> when i open the above mentioned script, google tells me i have no
>>> parameter
>>> "sensor" ... which i can understand as ther is only a parameter amp ...
>>>
>>>
>>> Any ideas?
>>>
>>> Thanks,
>>>
>>> Georg
>>>
>>> --
>>> Georg Buschbeck
>>> Information Technology
>>>
>>> THOMAS DAILY GmbH
>>> Adlerstraße 19
>>> 79098 Freiburg
>>> Deutschland
>>> T + 49 761 3 85 59 502
>>> F + 49 761 3 85 59 550
>>> E gb@thomas-daily.de
>>> www.thomas-daily.de
>>>
>>> Geschäftsführer/Managing Directors:
>>> Wendy Thomas, Susanne Larbig
>>> Handelsregister Freiburg i.Br., HRB 3947
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>>> For additional commands, e-mail: users-help@wicket.apache.org
>>>
>>
>>
>>
>
>
> --
> Georg Buschbeck
> Information Technology
>
> THOMAS DAILY GmbH
> Adlerstraße 19
> 79098 Freiburg
> Deutschland
> T + 49 761 3 85 59 502
> F + 49 761 3 85 59 550
> E gb@thomas-daily.de
> www.thomas-daily.de
>
> Geschäftsführer/Managing Directors:
> Wendy Thomas, Susanne Larbig
> Handelsregister Freiburg i.Br., HRB 3947
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: JavaScriptReference
Posted by Georg Buschbeck <gb...@thomas-daily.de>.
Hi,
i attached it https://issues.apache.org/jira/browse/WICKET-4777 .
you can see the problem by clicking the show/hide link.
Thanks,
Georg
On 10/11/2012 08:55 AM, Martin Grigorov wrote:
> Hi,
>
> On Wed, Oct 10, 2012 at 6:20 PM, Georg Buschbeck <gb...@thomas-daily.de> wrote:
>> Hi
>>
>> one addition, so i've seen you've fixed that issue (WICKET-4777) , but i
>> think, there is a part missing, which i also didn't think of.
>>
>> on the delivered page the html code looks fine now (switched to
>> 6.2.0-SNAPSHOT).
>> --snip--
>> <script type="text/javascript"
>> src="http://maps.googleapis.com/maps/api/js?sensor=false&client-id=google-id&callback=initialize"></script>
>> --snap--
>> when doing an ajax request whose response contains that rendered url it is
>> represented the same way ..
>>
>> --snip--
>> <header-contribution encoding="wicket1" ><![CDATA[<head
>> xmlns:wicket="http://wicket.apache.org"><script type="text/javascript"
>> src="http://maps.googleapis.com/maps/api/js?sensor=false&client-id=google-id&callback=initialize"></script>
>> --snap--
>>
>>
>> which at this point leads to an javascript error:
>> --snip--
>> ERROR: Error in parsing: This page contains the following errors:error on
>> line 1 at column 98: EntityRef: expecting ';'
>> Below is a rendering of the page up to the first error.
>> --snap--
>>
>> so i guess, it has to be escaped?
>
> Can you please create a quickstart and attach it to the ticket.
> Thanks!
>
>>
>>
>> Thanks,
>>
>> Georg
>>
>>
>>
>> On 09/21/2012 01:00 PM, Georg Buschbeck wrote:
>>>
>>> okay, i filed a bug report ...
>>>
>>>
>>>
>>> On 09/21/2012 11:59 AM, Martin Grigorov wrote:
>>>>
>>>> Hi,
>>>>
>>>> Looks like a bug.
>>>>
>>>> On Fri, Sep 21, 2012 at 12:28 PM, Georg Buschbeck <gb...@thomas-daily.de>
>>>> wrote:
>>>>>
>>>>> hi
>>>>>
>>>>> while trying to integrate gmaps3 in our webapp i had issues with the
>>>>> wicketstuff-gmap3 stuff ( - we need a client-id for our request) ...
>>>>>
>>>>> so i have:
>>>>>
>>>>> public static final String GMAP_API_URL =
>>>>> "%s://maps.google.com/maps/api/js?v=3&sensor=%s&client-id=%s";
>>>>>
>>>>> response.render(JavaScriptHeaderItem.forUrl(String.format(GMAP_API_URL,
>>>>> schema, sensor, clientid)));
>>>>>
>>>>>
>>>>> the rendered result of this is:
>>>>> <script type="text/javascript"
>>>>>
>>>>> src="http://maps.google.com/maps/api/js?v=3&sensor=false&client-id=...."></script>
>>>>>
>>>>>
>>>>>
>>>>> so the requestparameters are encoded
>>>>>
>>>>> which is happening in the JavaScriptUtils Helper:
>>>>> public static void writeJavaScriptUrl(final Response response, final
>>>>> CharSequence url, final String id, boolean defer, String charset)
>>>>> {
>>>>> response.write("<script type=\"text/javascript\" ");
>>>>> if (id != null)
>>>>> {
>>>>> response.write("id=\"" +
>>>>> Strings.escapeMarkup(id) +
>>>>> "\" ");
>>>>> }
>>>>> if (defer)
>>>>> {
>>>>> response.write("defer=\"defer\" ");
>>>>> }
>>>>> if (charset != null)
>>>>> {
>>>>> response.write("charset=\"" +
>>>>> Strings.escapeMarkup(charset) + "\" ");
>>>>> }
>>>>> response.write("src=\"");
>>>>> response.write(Strings.escapeMarkup(url));
>>>>> response.write("\"></script>");
>>>>> response.write("\n");
>>>>> }
>>>>>
>>>>> but ... is this right to escape the url?
>>>>>
>>>>> when i open the above mentioned script, google tells me i have no
>>>>> parameter
>>>>> "sensor" ... which i can understand as ther is only a parameter amp ...
>>>>>
>>>>>
>>>>> Any ideas?
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Georg
>>>>>
>>>>> --
>>>>> Georg Buschbeck
>>>>> Information Technology
>>>>>
>>>>> THOMAS DAILY GmbH
>>>>> Adlerstraße 19
>>>>> 79098 Freiburg
>>>>> Deutschland
>>>>> T + 49 761 3 85 59 502
>>>>> F + 49 761 3 85 59 550
>>>>> E gb@thomas-daily.de
>>>>> www.thomas-daily.de
>>>>>
>>>>> Geschäftsführer/Managing Directors:
>>>>> Wendy Thomas, Susanne Larbig
>>>>> Handelsregister Freiburg i.Br., HRB 3947
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>>>>> For additional commands, e-mail: users-help@wicket.apache.org
>>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>> --
>> Georg Buschbeck
>> Information Technology
>>
>> THOMAS DAILY GmbH
>> Adlerstraße 19
>> 79098 Freiburg
>> Deutschland
>> T + 49 761 3 85 59 502
>> F + 49 761 3 85 59 550
>> E gb@thomas-daily.de
>> www.thomas-daily.de
>>
>> Geschäftsführer/Managing Directors:
>> Wendy Thomas, Susanne Larbig
>> Handelsregister Freiburg i.Br., HRB 3947
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>
>
>
--
Georg Buschbeck
Information Technology
THOMAS DAILY GmbH
Adlerstraße 19
79098 Freiburg
Deutschland
T + 49 761 3 85 59 502
F + 49 761 3 85 59 550
E gb@thomas-daily.de
www.thomas-daily.de
Geschäftsführer/Managing Directors:
Wendy Thomas, Susanne Larbig
Handelsregister Freiburg i.Br., HRB 3947
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: JavaScriptReference
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
On Wed, Oct 10, 2012 at 6:20 PM, Georg Buschbeck <gb...@thomas-daily.de> wrote:
> Hi
>
> one addition, so i've seen you've fixed that issue (WICKET-4777) , but i
> think, there is a part missing, which i also didn't think of.
>
> on the delivered page the html code looks fine now (switched to
> 6.2.0-SNAPSHOT).
> --snip--
> <script type="text/javascript"
> src="http://maps.googleapis.com/maps/api/js?sensor=false&client-id=google-id&callback=initialize"></script>
> --snap--
> when doing an ajax request whose response contains that rendered url it is
> represented the same way ..
>
> --snip--
> <header-contribution encoding="wicket1" ><![CDATA[<head
> xmlns:wicket="http://wicket.apache.org"><script type="text/javascript"
> src="http://maps.googleapis.com/maps/api/js?sensor=false&client-id=google-id&callback=initialize"></script>
> --snap--
>
>
> which at this point leads to an javascript error:
> --snip--
> ERROR: Error in parsing: This page contains the following errors:error on
> line 1 at column 98: EntityRef: expecting ';'
> Below is a rendering of the page up to the first error.
> --snap--
>
> so i guess, it has to be escaped?
Can you please create a quickstart and attach it to the ticket.
Thanks!
>
>
> Thanks,
>
> Georg
>
>
>
> On 09/21/2012 01:00 PM, Georg Buschbeck wrote:
>>
>> okay, i filed a bug report ...
>>
>>
>>
>> On 09/21/2012 11:59 AM, Martin Grigorov wrote:
>>>
>>> Hi,
>>>
>>> Looks like a bug.
>>>
>>> On Fri, Sep 21, 2012 at 12:28 PM, Georg Buschbeck <gb...@thomas-daily.de>
>>> wrote:
>>>>
>>>> hi
>>>>
>>>> while trying to integrate gmaps3 in our webapp i had issues with the
>>>> wicketstuff-gmap3 stuff ( - we need a client-id for our request) ...
>>>>
>>>> so i have:
>>>>
>>>> public static final String GMAP_API_URL =
>>>> "%s://maps.google.com/maps/api/js?v=3&sensor=%s&client-id=%s";
>>>>
>>>> response.render(JavaScriptHeaderItem.forUrl(String.format(GMAP_API_URL,
>>>> schema, sensor, clientid)));
>>>>
>>>>
>>>> the rendered result of this is:
>>>> <script type="text/javascript"
>>>>
>>>> src="http://maps.google.com/maps/api/js?v=3&sensor=false&client-id=...."></script>
>>>>
>>>>
>>>>
>>>> so the requestparameters are encoded
>>>>
>>>> which is happening in the JavaScriptUtils Helper:
>>>> public static void writeJavaScriptUrl(final Response response, final
>>>> CharSequence url, final String id, boolean defer, String charset)
>>>> {
>>>> response.write("<script type=\"text/javascript\" ");
>>>> if (id != null)
>>>> {
>>>> response.write("id=\"" +
>>>> Strings.escapeMarkup(id) +
>>>> "\" ");
>>>> }
>>>> if (defer)
>>>> {
>>>> response.write("defer=\"defer\" ");
>>>> }
>>>> if (charset != null)
>>>> {
>>>> response.write("charset=\"" +
>>>> Strings.escapeMarkup(charset) + "\" ");
>>>> }
>>>> response.write("src=\"");
>>>> response.write(Strings.escapeMarkup(url));
>>>> response.write("\"></script>");
>>>> response.write("\n");
>>>> }
>>>>
>>>> but ... is this right to escape the url?
>>>>
>>>> when i open the above mentioned script, google tells me i have no
>>>> parameter
>>>> "sensor" ... which i can understand as ther is only a parameter amp ...
>>>>
>>>>
>>>> Any ideas?
>>>>
>>>> Thanks,
>>>>
>>>> Georg
>>>>
>>>> --
>>>> Georg Buschbeck
>>>> Information Technology
>>>>
>>>> THOMAS DAILY GmbH
>>>> Adlerstraße 19
>>>> 79098 Freiburg
>>>> Deutschland
>>>> T + 49 761 3 85 59 502
>>>> F + 49 761 3 85 59 550
>>>> E gb@thomas-daily.de
>>>> www.thomas-daily.de
>>>>
>>>> Geschäftsführer/Managing Directors:
>>>> Wendy Thomas, Susanne Larbig
>>>> Handelsregister Freiburg i.Br., HRB 3947
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>>>> For additional commands, e-mail: users-help@wicket.apache.org
>>>>
>>>
>>>
>>>
>>
>>
>
>
> --
> Georg Buschbeck
> Information Technology
>
> THOMAS DAILY GmbH
> Adlerstraße 19
> 79098 Freiburg
> Deutschland
> T + 49 761 3 85 59 502
> F + 49 761 3 85 59 550
> E gb@thomas-daily.de
> www.thomas-daily.de
>
> Geschäftsführer/Managing Directors:
> Wendy Thomas, Susanne Larbig
> Handelsregister Freiburg i.Br., HRB 3947
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: JavaScriptReference
Posted by Georg Buschbeck <gb...@thomas-daily.de>.
Hi
one addition, so i've seen you've fixed that issue (WICKET-4777) , but i
think, there is a part missing, which i also didn't think of.
on the delivered page the html code looks fine now (switched to
6.2.0-SNAPSHOT).
--snip--
<script type="text/javascript"
src="http://maps.googleapis.com/maps/api/js?sensor=false&client-id=google-id&callback=initialize"></script>
--snap--
when doing an ajax request whose response contains that rendered url it
is represented the same way ..
--snip--
<header-contribution encoding="wicket1" ><![CDATA[<head
xmlns:wicket="http://wicket.apache.org"><script type="text/javascript"
src="http://maps.googleapis.com/maps/api/js?sensor=false&client-id=google-id&callback=initialize"></script>
--snap--
which at this point leads to an javascript error:
--snip--
ERROR: Error in parsing: This page contains the following errors:error
on line 1 at column 98: EntityRef: expecting ';'
Below is a rendering of the page up to the first error.
--snap--
so i guess, it has to be escaped?
Thanks,
Georg
On 09/21/2012 01:00 PM, Georg Buschbeck wrote:
> okay, i filed a bug report ...
>
>
>
> On 09/21/2012 11:59 AM, Martin Grigorov wrote:
>> Hi,
>>
>> Looks like a bug.
>>
>> On Fri, Sep 21, 2012 at 12:28 PM, Georg Buschbeck <gb...@thomas-daily.de>
>> wrote:
>>> hi
>>>
>>> while trying to integrate gmaps3 in our webapp i had issues with the
>>> wicketstuff-gmap3 stuff ( - we need a client-id for our request) ...
>>>
>>> so i have:
>>>
>>> public static final String GMAP_API_URL =
>>> "%s://maps.google.com/maps/api/js?v=3&sensor=%s&client-id=%s";
>>>
>>> response.render(JavaScriptHeaderItem.forUrl(String.format(GMAP_API_URL,
>>> schema, sensor, clientid)));
>>>
>>>
>>> the rendered result of this is:
>>> <script type="text/javascript"
>>> src="http://maps.google.com/maps/api/js?v=3&sensor=false&client-id=...."></script>
>>>
>>>
>>>
>>> so the requestparameters are encoded
>>>
>>> which is happening in the JavaScriptUtils Helper:
>>> public static void writeJavaScriptUrl(final Response response, final
>>> CharSequence url, final String id, boolean defer, String charset)
>>> {
>>> response.write("<script type=\"text/javascript\" ");
>>> if (id != null)
>>> {
>>> response.write("id=\"" +
>>> Strings.escapeMarkup(id) +
>>> "\" ");
>>> }
>>> if (defer)
>>> {
>>> response.write("defer=\"defer\" ");
>>> }
>>> if (charset != null)
>>> {
>>> response.write("charset=\"" +
>>> Strings.escapeMarkup(charset) + "\" ");
>>> }
>>> response.write("src=\"");
>>> response.write(Strings.escapeMarkup(url));
>>> response.write("\"></script>");
>>> response.write("\n");
>>> }
>>>
>>> but ... is this right to escape the url?
>>>
>>> when i open the above mentioned script, google tells me i have no
>>> parameter
>>> "sensor" ... which i can understand as ther is only a parameter amp ...
>>>
>>>
>>> Any ideas?
>>>
>>> Thanks,
>>>
>>> Georg
>>>
>>> --
>>> Georg Buschbeck
>>> Information Technology
>>>
>>> THOMAS DAILY GmbH
>>> Adlerstraße 19
>>> 79098 Freiburg
>>> Deutschland
>>> T + 49 761 3 85 59 502
>>> F + 49 761 3 85 59 550
>>> E gb@thomas-daily.de
>>> www.thomas-daily.de
>>>
>>> Geschäftsführer/Managing Directors:
>>> Wendy Thomas, Susanne Larbig
>>> Handelsregister Freiburg i.Br., HRB 3947
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>>> For additional commands, e-mail: users-help@wicket.apache.org
>>>
>>
>>
>>
>
>
--
Georg Buschbeck
Information Technology
THOMAS DAILY GmbH
Adlerstraße 19
79098 Freiburg
Deutschland
T + 49 761 3 85 59 502
F + 49 761 3 85 59 550
E gb@thomas-daily.de
www.thomas-daily.de
Geschäftsführer/Managing Directors:
Wendy Thomas, Susanne Larbig
Handelsregister Freiburg i.Br., HRB 3947
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: JavaScriptReference
Posted by Georg Buschbeck <gb...@thomas-daily.de>.
okay, i filed a bug report ...
On 09/21/2012 11:59 AM, Martin Grigorov wrote:
> Hi,
>
> Looks like a bug.
>
> On Fri, Sep 21, 2012 at 12:28 PM, Georg Buschbeck <gb...@thomas-daily.de> wrote:
>> hi
>>
>> while trying to integrate gmaps3 in our webapp i had issues with the
>> wicketstuff-gmap3 stuff ( - we need a client-id for our request) ...
>>
>> so i have:
>>
>> public static final String GMAP_API_URL =
>> "%s://maps.google.com/maps/api/js?v=3&sensor=%s&client-id=%s";
>>
>> response.render(JavaScriptHeaderItem.forUrl(String.format(GMAP_API_URL,
>> schema, sensor, clientid)));
>>
>>
>> the rendered result of this is:
>> <script type="text/javascript"
>> src="http://maps.google.com/maps/api/js?v=3&sensor=false&client-id=...."></script>
>>
>>
>> so the requestparameters are encoded
>>
>> which is happening in the JavaScriptUtils Helper:
>> public static void writeJavaScriptUrl(final Response response, final
>> CharSequence url, final String id, boolean defer, String charset)
>> {
>> response.write("<script type=\"text/javascript\" ");
>> if (id != null)
>> {
>> response.write("id=\"" + Strings.escapeMarkup(id) +
>> "\" ");
>> }
>> if (defer)
>> {
>> response.write("defer=\"defer\" ");
>> }
>> if (charset != null)
>> {
>> response.write("charset=\"" +
>> Strings.escapeMarkup(charset) + "\" ");
>> }
>> response.write("src=\"");
>> response.write(Strings.escapeMarkup(url));
>> response.write("\"></script>");
>> response.write("\n");
>> }
>>
>> but ... is this right to escape the url?
>>
>> when i open the above mentioned script, google tells me i have no parameter
>> "sensor" ... which i can understand as ther is only a parameter amp ...
>>
>>
>> Any ideas?
>>
>> Thanks,
>>
>> Georg
>>
>> --
>> Georg Buschbeck
>> Information Technology
>>
>> THOMAS DAILY GmbH
>> Adlerstraße 19
>> 79098 Freiburg
>> Deutschland
>> T + 49 761 3 85 59 502
>> F + 49 761 3 85 59 550
>> E gb@thomas-daily.de
>> www.thomas-daily.de
>>
>> Geschäftsführer/Managing Directors:
>> Wendy Thomas, Susanne Larbig
>> Handelsregister Freiburg i.Br., HRB 3947
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>
>
>
--
Georg Buschbeck
Information Technology
THOMAS DAILY GmbH
Adlerstraße 19
79098 Freiburg
Deutschland
T + 49 761 3 85 59 502
F + 49 761 3 85 59 550
E gb@thomas-daily.de
www.thomas-daily.de
Geschäftsführer/Managing Directors:
Wendy Thomas, Susanne Larbig
Handelsregister Freiburg i.Br., HRB 3947
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: JavaScriptReference
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
Looks like a bug.
On Fri, Sep 21, 2012 at 12:28 PM, Georg Buschbeck <gb...@thomas-daily.de> wrote:
> hi
>
> while trying to integrate gmaps3 in our webapp i had issues with the
> wicketstuff-gmap3 stuff ( - we need a client-id for our request) ...
>
> so i have:
>
> public static final String GMAP_API_URL =
> "%s://maps.google.com/maps/api/js?v=3&sensor=%s&client-id=%s";
>
> response.render(JavaScriptHeaderItem.forUrl(String.format(GMAP_API_URL,
> schema, sensor, clientid)));
>
>
> the rendered result of this is:
> <script type="text/javascript"
> src="http://maps.google.com/maps/api/js?v=3&sensor=false&client-id=...."></script>
>
>
> so the requestparameters are encoded
>
> which is happening in the JavaScriptUtils Helper:
> public static void writeJavaScriptUrl(final Response response, final
> CharSequence url, final String id, boolean defer, String charset)
> {
> response.write("<script type=\"text/javascript\" ");
> if (id != null)
> {
> response.write("id=\"" + Strings.escapeMarkup(id) +
> "\" ");
> }
> if (defer)
> {
> response.write("defer=\"defer\" ");
> }
> if (charset != null)
> {
> response.write("charset=\"" +
> Strings.escapeMarkup(charset) + "\" ");
> }
> response.write("src=\"");
> response.write(Strings.escapeMarkup(url));
> response.write("\"></script>");
> response.write("\n");
> }
>
> but ... is this right to escape the url?
>
> when i open the above mentioned script, google tells me i have no parameter
> "sensor" ... which i can understand as ther is only a parameter amp ...
>
>
> Any ideas?
>
> Thanks,
>
> Georg
>
> --
> Georg Buschbeck
> Information Technology
>
> THOMAS DAILY GmbH
> Adlerstraße 19
> 79098 Freiburg
> Deutschland
> T + 49 761 3 85 59 502
> F + 49 761 3 85 59 550
> E gb@thomas-daily.de
> www.thomas-daily.de
>
> Geschäftsführer/Managing Directors:
> Wendy Thomas, Susanne Larbig
> Handelsregister Freiburg i.Br., HRB 3947
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org