[jira] [Commented] (FLINK-6981) Add shaded guava dependency

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063206#comment-16063206 ] 

ASF GitHub Bot commented on FLINK-6981:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink-shaded/pull/1#discussion_r124032645
  
    --- Diff: flink-shaded-guava-18/pom.xml ---
    @@ -0,0 +1,99 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    +
    +    <modelVersion>4.0.0</modelVersion>
    +
    +    <parent>
    +        <groupId>org.apache.flink</groupId>
    +        <artifactId>flink-shaded</artifactId>
    +        <version>1.0</version>
    +        <relativePath>..</relativePath>
    +    </parent>
    +
    +    <artifactId>flink-shaded-guava-18</artifactId>
    +    <name>flink-shaded-guava-18</name>
    +    <version>1.0-${guava.version}</version>
    +
    +    <packaging>jar</packaging>
    +
    +    <properties>
    +        <guava.version>18.0</guava.version>
    +    </properties>
    +
    +    <dependencies>
    +        <dependency>
    +            <groupId>com.google.guava</groupId>
    +            <artifactId>guava</artifactId>
    +            <version>${guava.version}</version>
    +            <optional>true</optional>
    --- End diff --
    
    Why is the dependency optional?


> Add shaded guava dependency
> ---------------------------
>
>                 Key: FLINK-6981
>                 URL: https://issues.apache.org/jira/browse/FLINK-6981
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Build System
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)