You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Hyukjin Kwon (JIRA)" <ji...@apache.org> on 2019/05/21 04:13:36 UTC

[jira] [Resolved] (SPARK-9139) Add backwards-compatibility tests for DataType.fromJson()

     [ https://issues.apache.org/jira/browse/SPARK-9139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hyukjin Kwon resolved SPARK-9139.
---------------------------------
    Resolution: Incomplete

> Add backwards-compatibility tests for DataType.fromJson()
> ---------------------------------------------------------
>
>                 Key: SPARK-9139
>                 URL: https://issues.apache.org/jira/browse/SPARK-9139
>             Project: Spark
>          Issue Type: Test
>          Components: SQL
>            Reporter: Josh Rosen
>            Priority: Major
>              Labels: bulk-closed
>
> SQL's DataType.fromJson is a public API and thus must be backwards-compatible; there are also backwards-compatibility concerns related to persistence of DataType JSON in metastores.
> Unfortunately, we do not have any backwards-compatibility tests which attempt to read old JSON values that were written by earlier versions of Spark.  DataTypeSuite has "roundtrip" tests that test fromJson(toJson(foo)), but this doesn't ensure compatibility.
> I think that we should address this by capuring the JSON strings produced in Spark 1.3's DataFrameSuite and adding test cases that try to create DataTypes from those strings.
> This might be a good starter task for someone who wants to contribute to SQL tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org