You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/07/04 10:40:28 UTC
Review Request 12264: CLOUDSTACK-3351: Fix add cluster API to set right
hypervisor type
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12264/
-----------------------------------------------------------
Review request for cloudstack and Abhinandan Prateek.
Bugs: CLOUDSTACK-3351
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type
In AddCluster API we validate Hypervisor type parameter even if it is case insensitive. We should not put this case insensitive value in the DB which may lead to mismatch with hypervisor type with other tables in DB leading to failure of various DB queries.
Diffs
-----
server/src/com/cloud/resource/ResourceManagerImpl.java c6e8d7d
Diff: https://reviews.apache.org/r/12264/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 12264: CLOUDSTACK-3351: Fix add cluster API to set right
hypervisor type
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12264/#review22756
-----------------------------------------------------------
Commit 968c252ca58fe55285004355dd1060fd1ae9aeb4 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=968c252 ]
CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
- ASF Subversion and Git Services
On July 4, 2013, 8:40 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12264/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 8:40 a.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Bugs: CLOUDSTACK-3351
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type
> In AddCluster API we validate Hypervisor type parameter even if it is case insensitive. We should not put this case insensitive value in the DB which may lead to mismatch with hypervisor type with other tables in DB leading to failure of various DB queries.
>
>
> Diffs
> -----
>
> server/src/com/cloud/resource/ResourceManagerImpl.java c6e8d7d
>
> Diff: https://reviews.apache.org/r/12264/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12264: CLOUDSTACK-3351: Fix add cluster API to set right
hypervisor type
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12264/#review24425
-----------------------------------------------------------
Commit b4fe0252230e74d36f62679cd2a751f278edacc1 in branch refs/heads/4.2 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b4fe025 ]
CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
- ASF Subversion and Git Services
On July 4, 2013, 8:40 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12264/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 8:40 a.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Bugs: CLOUDSTACK-3351
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type
> In AddCluster API we validate Hypervisor type parameter even if it is case insensitive. We should not put this case insensitive value in the DB which may lead to mismatch with hypervisor type with other tables in DB leading to failure of various DB queries.
>
>
> Diffs
> -----
>
> server/src/com/cloud/resource/ResourceManagerImpl.java c6e8d7d
>
> Diff: https://reviews.apache.org/r/12264/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12264: CLOUDSTACK-3351: Fix add cluster API to set right
hypervisor type
Posted by Harikrishna Patnala <ha...@citrix.com>.
> On July 4, 2013, 9:10 a.m., Nitin Mehta wrote:
> > Since we have already put it to be case insensitive will this be causing issues for upgrade or anywhere else we are comparing. This is concerning
As long as we get hypervisor type from clusterVO there is no problem since VO converts it to right hypervisor type.
But there might be a problem if there are any queries taking hypervisor type from cluster table.
- Harikrishna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12264/#review22759
-----------------------------------------------------------
On July 4, 2013, 8:40 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12264/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 8:40 a.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Bugs: CLOUDSTACK-3351
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type
> In AddCluster API we validate Hypervisor type parameter even if it is case insensitive. We should not put this case insensitive value in the DB which may lead to mismatch with hypervisor type with other tables in DB leading to failure of various DB queries.
>
>
> Diffs
> -----
>
> server/src/com/cloud/resource/ResourceManagerImpl.java c6e8d7d
>
> Diff: https://reviews.apache.org/r/12264/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12264: CLOUDSTACK-3351: Fix add cluster API to set right
hypervisor type
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12264/#review22759
-----------------------------------------------------------
Since we have already put it to be case insensitive will this be causing issues for upgrade or anywhere else we are comparing. This is concerning
- Nitin Mehta
On July 4, 2013, 8:40 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12264/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 8:40 a.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Bugs: CLOUDSTACK-3351
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type
> In AddCluster API we validate Hypervisor type parameter even if it is case insensitive. We should not put this case insensitive value in the DB which may lead to mismatch with hypervisor type with other tables in DB leading to failure of various DB queries.
>
>
> Diffs
> -----
>
> server/src/com/cloud/resource/ResourceManagerImpl.java c6e8d7d
>
> Diff: https://reviews.apache.org/r/12264/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>