[GitHub] [superset] lyndsiWilliams commented on a diff in pull request #22610: feat: Enable new dataset creation flow

[GitBox <gi...@apache.org>]

lyndsiWilliams commented on code in PR #22610:
URL: https://github.com/apache/superset/pull/22610#discussion_r1064812755


##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/Footer/index.tsx:
##########
@@ -104,7 +100,8 @@ function Footer({
         if (typeof response === 'number') {
           logEvent(LOG_ACTIONS_DATASET_CREATION_SUCCESS, datasetObject);
           // When a dataset is created the response we get is its ID number
-          goToPreviousUrl();
+          window.location.href =

Review Comment:
   I think originally we were rerouting to the dataset list so the user can see the dataset they just created. I'm gonna bring in @yousoph for this one, should the user be redirected to the dataset list or their previous page after creating a dataset?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org