You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Gergely Novák (JIRA)" <ji...@apache.org> on 2017/01/04 09:31:58 UTC
[jira] [Commented] (MAPREDUCE-6825)
YARNRunner#createApplicationSubmissionContext method is longer than 150
lines
[ https://issues.apache.org/jira/browse/MAPREDUCE-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797772#comment-15797772 ]
Gergely Novák commented on MAPREDUCE-6825:
------------------------------------------
Attached a simple patch with a refactor that splits the method into 3: setupLocalResources, setupAMCommand and setupContainerLaunchContextForAM. [~ctrezzo] did you mean something like this?
> YARNRunner#createApplicationSubmissionContext method is longer than 150 lines
> -----------------------------------------------------------------------------
>
> Key: MAPREDUCE-6825
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6825
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Chris Trezzo
> Priority: Trivial
> Labels: newbie
> Attachments: MAPREDUCE-6825.001.patch
>
>
> bq. ./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java:341: public ApplicationSubmissionContext createApplicationSubmissionContext(:3: Method length is 249 lines (max allowed is 150).
> {{YARNRunner#createApplicationSubmissionContext}} is longer than 150 lines and needs to be refactored.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org