You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org> on 2013/07/18 20:45:01 UTC
[jira] [Commented] (LUCENE-5038) Don't call MergePolicy /
IndexWriter during DWPT Flush
[ https://issues.apache.org/jira/browse/LUCENE-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712644#comment-13712644 ]
Shalin Shekhar Mangar commented on LUCENE-5038:
-----------------------------------------------
This changed the LuceneTestCase.newLogMergePolicy method in a non backward compatible way.
{code}
- public static LogMergePolicy newLogMergePolicy(boolean useCFS, int mergeFactor) {
+ public static MergePolicy newLogMergePolicy(boolean useCFS, int mergeFactor) {
{code}
> Don't call MergePolicy / IndexWriter during DWPT Flush
> ------------------------------------------------------
>
> Key: LUCENE-5038
> URL: https://issues.apache.org/jira/browse/LUCENE-5038
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Affects Versions: 5.0, 4.3
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 5.0, 4.4
>
> Attachments: LUCENE-5038.patch, LUCENE-5038.patch, LUCENE-5038.patch, LUCENE-5038.patch, LUCENE-5038.patch, LUCENE-5038.patch
>
>
> We currently consult the indexwriter -> merge policy to decide if we need to write CFS or not which is bad in many ways.
> - we should call mergepolicy only during merges
> - we should never sync on IW during DWPT flush
> - we should be able to make the decision if we need to write CFS or not before flush, ie. we could write parts of the flush directly to CFS or even start writing stored fields directly.
> - in the NRT case it might make sense to write all flushes to CFS to minimize filedescriptors independent of the index size.
> I wonder if we can use a simple boolean for this in the IWC and get away with not consulting merge policy. This would simplify concurrency a lot here already.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org