You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by li...@apache.org on 2020/09/22 11:51:28 UTC

[submarine] branch master updated: SUBMARINE-630. [E2E_Test] Improve notebookIT.java

This is an automated email from the ASF dual-hosted git repository.

liuxun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git


The following commit(s) were added to refs/heads/master by this push:
     new cf7142d  SUBMARINE-630. [E2E_Test] Improve notebookIT.java
cf7142d is described below

commit cf7142dcf249ffc4b33e4174f37712ea4cd2486f
Author: kobe860219 <ko...@gmail.com>
AuthorDate: Tue Sep 22 15:05:24 2020 +0800

    SUBMARINE-630. [E2E_Test] Improve notebookIT.java
    
    ### What is this PR for?
    Improve notebookIT.java to test notebook page for creating new notebook.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/SUBMARINE-630
    
    ### How should this be tested?
    https://travis-ci.org/github/kobe860219/submarine/builds/729190458
    
    ### Screenshots (if appropriate)
    <img width="808" alt="ζˆͺεœ– 2020-09-22 上午11 03 08" src="https://user-images.githubusercontent.com/48027290/93840825-551d6200-fcc4-11ea-84e2-b0a9b3ae49a3.png">
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: kobe860219 <ko...@gmail.com>
    
    Closes #408 from kobe860219/SUBMARINE-630 and squashes the following commits:
    
    6e73981 [kobe860219] SUBMARINE-630. [E2E_Test] Improve notebookIT.java
    6a44767 [kobe860219] SUBMARINE-630. [E2E_Test] Improve notebookIT.java
---
 .../org/apache/submarine/integration/notebookIT.java | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/notebookIT.java b/submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/notebookIT.java
index 2c8b52e..af24ae6 100644
--- a/submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/notebookIT.java
+++ b/submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/notebookIT.java
@@ -56,5 +56,25 @@ public class notebookIT extends AbstractSubmarineIT {
     pollingWait(By.xpath("//span[contains(text(), \"Notebook\")]"), MAX_BROWSER_TIMEOUT_SEC).click();
     Assert.assertEquals(driver.getCurrentUrl(), "http://localhost:8080/workbench/notebook");
 
+    // Test for creating new notebook
+    LOG.info("Create Notebook Test");
+    pollingWait(By.xpath("//button[@id='btnNewNotebook']"), MAX_BROWSER_TIMEOUT_SEC).click();
+    pollingWait(By.cssSelector("input[ng-reflect-name='notebookName']"), MAX_BROWSER_TIMEOUT_SEC).sendKeys("test-nb");
+    pollingWait(By.cssSelector("input[ng-reflect-name='cpus']"), MAX_BROWSER_TIMEOUT_SEC).clear();
+    pollingWait(By.cssSelector("input[ng-reflect-name='cpus']"), MAX_BROWSER_TIMEOUT_SEC).sendKeys("2");
+    pollingWait(By.cssSelector("input[ng-reflect-name='gpus']"), MAX_BROWSER_TIMEOUT_SEC).clear();
+    pollingWait(By.cssSelector("input[ng-reflect-name='gpus']"), MAX_BROWSER_TIMEOUT_SEC).sendKeys("1");
+    pollingWait(By.cssSelector("input[ng-reflect-name='memoryNum']"), MAX_BROWSER_TIMEOUT_SEC).sendKeys("1024");
+    pollingWait(By.xpath("//button[@id='envVar-btn']"), MAX_BROWSER_TIMEOUT_SEC).click();
+    pollingWait(By.xpath("//input[@name='key0']"), MAX_BROWSER_TIMEOUT_SEC).sendKeys("testKey0");
+    pollingWait(By.xpath("//input[@name='value0']"), MAX_BROWSER_TIMEOUT_SEC).sendKeys("testValue0");
+    pollingWait(By.xpath("//button[@id='go']"), MAX_BROWSER_TIMEOUT_SEC).click();
+    /*
+    Future add k8s test.
+    Assert.assertEquals(pollingWait(By.xpath("//td[contains(., 'test-nb')]"), MAX_BROWSER_TIMEOUT_SEC).isDisplayed(), true);
+    */
+    Assert.assertEquals(pollingWait(By.xpath("//button[@id='btnNewNotebook']"), MAX_BROWSER_TIMEOUT_SEC).isDisplayed(), true);
+    LOG.info("Test Success!");
+
   }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org