[GitHub] [activemq-artemis] gtully commented on a diff in pull request #4549: ARTEMIS-4356 ensure match regexp expression is anchored on eot to avo…

["gtully (via GitHub)" <gi...@apache.org>]

gtully commented on code in PR #4549:
URL: https://github.com/apache/activemq-artemis/pull/4549#discussion_r1261342410


##########
artemis-server/src/test/java/org/apache/activemq/artemis/core/settings/impl/MatchTest.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.core.settings.impl;
+
+import java.util.function.Predicate;
+import java.util.regex.Pattern;
+
+import org.apache.activemq.artemis.core.config.WildcardConfiguration;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class MatchTest {
+
+   @Test
+   public void predicateTestAnyChild() {
+
+      final Match<?> underTest = new Match<>("test.#", null, new WildcardConfiguration());
+      final Predicate<String> predicate = underTest.getPattern().asPredicate();
+
+      Assert.assertTrue(predicate.test("test"));
+      Assert.assertTrue(predicate.test("test.A"));
+      Assert.assertTrue(predicate.test("test.A.B"));
+
+      Assert.assertFalse(predicate.test("testing.A"));
+   }
+
+   @Test
+   public void predicateTestAnyWord() {
+
+      final Match<?> underTest = new Match<>("test.*", null, new WildcardConfiguration());
+      final Predicate<String> predicate = underTest.getPattern().asPredicate();
+
+      Assert.assertTrue(predicate.test("test.A"));
+
+      Assert.assertFalse(predicate.test("testing.A"));
+      Assert.assertFalse(predicate.test("test"));
+      Assert.assertFalse(predicate.test("test.A.B"));
+   }
+
+   @Test
+   public void patterDirectAnyChild() {
+
+      final Pattern pattern = Match.createPattern("test.#", new WildcardConfiguration(), true);
+      final Predicate<String> predicate = pattern.asPredicate();
+
+      Assert.assertTrue(predicate.test("test.A"));
+      Assert.assertTrue(predicate.test("test.A.B"));
+
+      Assert.assertFalse(predicate.test("testing.A"));
+      Assert.assertFalse(predicate.test("test")); // Is this correct?

Review Comment:
   @jbertram this particular difference, I wonder if it is intentional?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org