You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Attila Király (JIRA)" <ji...@apache.org> on 2011/02/20 18:39:41 UTC
[jira] Created: (WICKET-3460) Relax BaseWicketTester's dependency
on MockServletContext to ServletContext
Relax BaseWicketTester's dependency on MockServletContext to ServletContext
---------------------------------------------------------------------------
Key: WICKET-3460
URL: https://issues.apache.org/jira/browse/WICKET-3460
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.5-RC1
Reporter: Attila Király
Priority: Minor
Currently BaseWicketTester enforces MockServletContext in constructor and in getter return value but this is not needed. A simple ServletContext dependency would allow to use other mock implementations in tests.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3460) Relax BaseWicketTester's dependency
on MockServletContext to ServletContext
Posted by "Attila Király (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Attila Király updated WICKET-3460:
----------------------------------
Attachment: fix-WICKET-3460.patch
Attaching patch againstr trunk. Tests pass.
> Relax BaseWicketTester's dependency on MockServletContext to ServletContext
> ---------------------------------------------------------------------------
>
> Key: WICKET-3460
> URL: https://issues.apache.org/jira/browse/WICKET-3460
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5-RC1
> Reporter: Attila Király
> Priority: Minor
> Attachments: fix-WICKET-3460.patch
>
>
> Currently BaseWicketTester enforces MockServletContext in constructor and in getter return value but this is not needed. A simple ServletContext dependency would allow to use other mock implementations in tests.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3460) Relax BaseWicketTester's dependency
on MockServletContext to ServletContext
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997179#comment-12997179 ]
Igor Vaynberg commented on WICKET-3460:
---------------------------------------
done, thanks.
> Relax BaseWicketTester's dependency on MockServletContext to ServletContext
> ---------------------------------------------------------------------------
>
> Key: WICKET-3460
> URL: https://issues.apache.org/jira/browse/WICKET-3460
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5-RC1
> Reporter: Attila Király
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.5-RC2
>
> Attachments: fix-WICKET-3460-2.patch, fix-WICKET-3460.patch
>
>
> Currently BaseWicketTester enforces MockServletContext in constructor and in getter return value but this is not needed. A simple ServletContext dependency would allow to use other mock implementations in tests.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (WICKET-3460) Relax BaseWicketTester's dependency
on MockServletContext to ServletContext
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3460.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-RC2
Assignee: Igor Vaynberg
> Relax BaseWicketTester's dependency on MockServletContext to ServletContext
> ---------------------------------------------------------------------------
>
> Key: WICKET-3460
> URL: https://issues.apache.org/jira/browse/WICKET-3460
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5-RC1
> Reporter: Attila Király
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.5-RC2
>
> Attachments: fix-WICKET-3460.patch
>
>
> Currently BaseWicketTester enforces MockServletContext in constructor and in getter return value but this is not needed. A simple ServletContext dependency would allow to use other mock implementations in tests.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3460) Relax BaseWicketTester's dependency
on MockServletContext to ServletContext
Posted by "Attila Király (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Attila Király updated WICKET-3460:
----------------------------------
Attachment: fix-WICKET-3460-2.patch
Can you please also apply this second patch? This adds a new constructor with ServletContext parameter to WicketTester.
> Relax BaseWicketTester's dependency on MockServletContext to ServletContext
> ---------------------------------------------------------------------------
>
> Key: WICKET-3460
> URL: https://issues.apache.org/jira/browse/WICKET-3460
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5-RC1
> Reporter: Attila Király
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.5-RC2
>
> Attachments: fix-WICKET-3460-2.patch, fix-WICKET-3460.patch
>
>
> Currently BaseWicketTester enforces MockServletContext in constructor and in getter return value but this is not needed. A simple ServletContext dependency would allow to use other mock implementations in tests.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira