You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Andrew Purtell <ap...@apache.org> on 2010/06/01 06:18:23 UTC

Review Request: REST tests could be a lot faster

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/109/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

In the meantime before HBASE-2564, the REST tests could be a lot faster than they are currently. Patch also updates tests with some style changes, mostly relaxing private scope to default.


This addresses bug HBASE-2638.
    http://issues.apache.org/jira/browse/HBASE-2638


Diffs
-----

  src/test/java/org/apache/hadoop/hbase/rest/TestRowResource.java be232cf 
  src/test/java/org/apache/hadoop/hbase/rest/TestScannerResource.java 67455e0 
  src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java 121d84e 
  src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java 5e53546 
  src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java 8606048 
  src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java 88fb93d 
  src/test/java/org/apache/hadoop/hbase/rest/TestVersionResource.java 22077cb 

Diff: http://review.hbase.org/r/109/diff


Testing
-------


Thanks,

Andrew

Re: Review Request: REST tests could be a lot faster

Posted by st...@duboce.net.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/109/#review111
-----------------------------------------------------------

Ship it!


+1


src/test/java/org/apache/hadoop/hbase/rest/TestRowResource.java
<http://review.hbase.org/r/109/#comment663>

    I think this access type is fine in tests



src/test/java/org/apache/hadoop/hbase/rest/TestRowResource.java
<http://review.hbase.org/r/109/#comment664>

    So, this is where you get the speedup from?  By setting up cluster once and then running all tests?  If so, thats good.



src/test/java/org/apache/hadoop/hbase/rest/TestRowResource.java
<http://review.hbase.org/r/109/#comment665>

    These tests could move to junit4 and HBaseTestingUtility in the future (different, low-priority issue)


- stack


On 2010-05-31 21:18:23, Andrew Purtell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/109/
> -----------------------------------------------------------
> 
> (Updated 2010-05-31 21:18:23)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> In the meantime before HBASE-2564, the REST tests could be a lot faster than they are currently. Patch also updates tests with some style changes, mostly relaxing private scope to default.
> 
> 
> This addresses bug HBASE-2638.
>     http://issues.apache.org/jira/browse/HBASE-2638
> 
> 
> Diffs
> -----
> 
>   src/test/java/org/apache/hadoop/hbase/rest/TestRowResource.java be232cf 
>   src/test/java/org/apache/hadoop/hbase/rest/TestScannerResource.java 67455e0 
>   src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java 121d84e 
>   src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java 5e53546 
>   src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java 8606048 
>   src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java 88fb93d 
>   src/test/java/org/apache/hadoop/hbase/rest/TestVersionResource.java 22077cb 
> 
> Diff: http://review.hbase.org/r/109/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew
> 
>