[GitHub] andrzej-kaczmarek opened a new pull request #93: nmxact: Make field name for uploaded data hash shorter

[GitBox <gi...@apache.org>]

andrzej-kaczmarek opened a new pull request #93: nmxact: Make field name for uploaded data hash shorter
URL: https://github.com/apache/mynewt-newtmgr/pull/93
 
 
   Let's use "sha" instead of "datahash" to keep it short.
   Long name like "datahash" not only adds few unnecessary bytes to data
   stream but also makes image upload fail with MCUBoot which does not
   handle long key names (no need to change it there though).
   
   "sha" name was chosen as it is short and should not be confused with
   image hash which is something different since data hash is computed
   over whole upload data, i.e. image with trailing data etc.).
   
   This fixes https://github.com/apache/mynewt-mcumgr-cli/issues/2.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services