[GitHub] [spark] yaooqinn commented on a change in pull request #27552: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #27552: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server
URL: https://github.com/apache/spark/pull/27552#discussion_r385493404
 
 

 ##########
 File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
 ##########
 @@ -178,7 +179,14 @@ private[hive] class SparkExecuteStatementOperation(
           }
           curCol += 1
         }
-        resultRowSet.addRow(row.toArray.asInstanceOf[Array[Object]])
+        // Convert date-time instances to types that are acceptable by Hive libs
+        // used in conversions to strings.
+        val resultRow = row.map {
+          case i: Instant => Timestamp.from(i)
 
 Review comment:
   There seems no java8 values to be add to the `row` buffer here by `SparkExecuteStatementOperation#addNonNullColumnValue `
   
   https://github.com/apache/spark/pull/27552/files#diff-72dcd8f81a51c8a815159fdf0332acdcR84-R116

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org