[GitHub] [rocketmq] lizhanhui commented on a diff in pull request #4731: [ISSUE #4721] remove code snippet It will never be executed

[GitBox <gi...@apache.org>]

lizhanhui commented on code in PR #4731:
URL: https://github.com/apache/rocketmq/pull/4731#discussion_r941005869


##########
controller/src/main/java/org/apache/rocketmq/controller/ControllerStartup.java:
##########
@@ -135,11 +135,7 @@ public static ControllerManager start(final ControllerManager controller) throws
             throw new IllegalArgumentException("ControllerManager is null");
         }
 
-        boolean initResult = controller.initialize();
-        if (!initResult) {
-            controller.shutdown();
-            System.exit(-3);
-        }
+        controller.initialize();

Review Comment:
   If initialize always returns true, why not change it to void?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org