You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/11/16 16:58:20 UTC

[GitHub] [beam] lostluck commented on a change in pull request #15993: [BEAM-13262] Forward for metrics.SingleResult

lostluck commented on a change in pull request #15993:
URL: https://github.com/apache/beam/pull/15993#discussion_r750479823



##########
File path: sdks/go/pkg/beam/forward.go
##########
@@ -215,3 +216,5 @@ var (
 
 // EventTimeType is the reflect.Type of EventTime.
 var EventTimeType = typex.EventTimeType
+

Review comment:
       Exported types, even type aliases, require their own doc comment.
   
   // MetricResult represents a single metric value, for use in writing predicate functions to query PipelineResults.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org