You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/05 04:30:22 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27460:
[SPARK-30733][R][HOTFIX] Fix SparkR tests per testthat and R version upgrade
HyukjinKwon commented on a change in pull request #27460: [SPARK-30733][R][HOTFIX] Fix SparkR tests per testthat and R version upgrade
URL: https://github.com/apache/spark/pull/27460#discussion_r375054369
##########
File path: R/create-rd.sh
##########
@@ -34,4 +34,5 @@ pushd "$FWDIR" > /dev/null
. "$FWDIR/find-r.sh"
# Generate Rd files if devtools is installed
-"$R_SCRIPT_PATH/Rscript" -e ' if("devtools" %in% rownames(installed.packages())) { library(devtools); devtools::document(pkg="./pkg", roclets=c("rd")) }'
+# TODO(SPARK-30737) reenable this once packages are correctly installed in Jenkins
Review comment:
This should be less critical since the SparkR tests themselves pass. I will summarize the summary for followup actions after I make it pass and merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org