[jira] [Commented] (PHOENIX-1863) Create unit test for inverting the pad character

["James Taylor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498569#comment-14498569 ] 

James Taylor commented on PHOENIX-1863:
---------------------------------------

[~Dumindux] - thanks for the new tests - these are good. Please also add a couple of tests that check the relative order of the byte[] too. For example test the sort order for a CHAR(5) that's DESC and ASC wrt to byte[] (you can use Bytes.BYTE_COMPARATOR) for the following kinds of values:
{code}
"foo"
"foo!"
"fooA"
"foo~"
{code}

[~ram_krish] - please review and commit after that.

> Create unit test for inverting the pad character
> ------------------------------------------------
>
>                 Key: PHOENIX-1863
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1863
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Assignee: Dumindu Buddhika
>             Fix For: 5.0.0, 4.4.0
>
>         Attachments: PHOENIX-1863.patch
>
>
> It'd be good to have unit tests that test the necessity of inverting the pad character (the parent JIRA).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)