You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by "martinzink (via GitHub)" <gi...@apache.org> on 2023/07/04 13:40:10 UTC

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1598: MINIFICPP-2156 fix for PutTCP trying to read passphrase from stdin

martinzink commented on code in PR #1598:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1598#discussion_r1252045663


##########
libminifi/CMakeLists.txt:
##########
@@ -78,7 +78,7 @@ endif()
 file(GLOB PROCESSOR_SOURCES  "src/processors/*.cpp" )
 
 
-add_library(core-minifi SHARED ${SOURCES})
+add_library(core-minifi SHARED ${SOURCES} include/utils/net/AsioSocketUtils.h)

Review Comment:
   that was probably my IDE automatically adding it, thanks for catching. removed it in https://github.com/apache/nifi-minifi-cpp/pull/1598/commits/3d451e15619339b1f54d65ee31f3c000a4f4e25f#diff-384b8bf2d8b6601d04935ea6bc051dee880b128f5add4fc99b66ca0f6a7bccbaL81 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org