You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/02/03 22:37:09 UTC

[GitHub] [incubator-pinot] jackjlli opened a new pull request #6540: Fix missing default admin port for pinot-server

jackjlli opened a new pull request #6540:
URL: https://github.com/apache/incubator-pinot/pull/6540


   ## Description
   The PR (https://github.com/apache/incubator-pinot/pull/6418) removed the default value of admin port for pinot-server. This makes pinot-servers  which don't have specified admin port in their instance configs fail to start the admin endpoints.
   
   Before this fix:
   ```
   $  lsof -i -P -n | grep LISTEN
   java    140  ...  ...  IPv6 ...      0t0  TCP *:15507 (LISTEN)
   java    140  ... ...  IPv6 ...      0t0  TCP *:8001 (LISTEN)
   ```
   
   After this fix:
   ```
   java    1231  ...  ...  IPv6 ...      0t0  TCP *:15507 (LISTEN)
   java    1231  ...  ...  IPv6 ...      0t0  TCP *:8097 (LISTEN)
   java    1231  ... ...  IPv6 ...      0t0  TCP *:8001 (LISTEN)
   ```
   ## Upgrade Notes
   Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
   * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
   
   Does this PR fix a zero-downtime upgrade introduced earlier?
   * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
   
   Does this PR otherwise need attention when creating release notes? Things to consider:
   - New configuration options
   - Deprecation of configurations
   - Signature changes to public methods/interfaces
   - New plugins added or old plugins removed
   * [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
   ## Release Notes
   If you have tagged this as either backward-incompat or release-notes,
   you MUST add text here that you would like to see appear in release notes of the
   next release.
   
   If you have a series of commits adding or enabling a feature, then
   add this section only in final commit that marks the feature completed.
   Refer to earlier release notes to see examples of text
   
   ## Documentation
   If you have introduced a new feature or configuration, please add it to the documentation as well.
   See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] jackjlli closed pull request #6540: Fix missing default admin port for pinot-server

Posted by GitBox <gi...@apache.org>.
jackjlli closed pull request #6540:
URL: https://github.com/apache/incubator-pinot/pull/6540


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] jackjlli commented on pull request #6540: Fix missing default admin port for pinot-server

Posted by GitBox <gi...@apache.org>.
jackjlli commented on pull request #6540:
URL: https://github.com/apache/incubator-pinot/pull/6540#issuecomment-772939032


   It seems the issue's been fixed in this PR (https://github.com/apache/incubator-pinot/pull/6515) where it fixes not only for pinot-controller, pinot-broker but also for pinot-server as well.
   We can close this PR now since it's duplicate.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org