[GitHub] [hbase] Apache9 commented on a change in pull request #2430: HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #2430:
URL: https://github.com/apache/hbase/pull/2430#discussion_r491910669



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java
##########
@@ -63,7 +121,7 @@ protected synchronized void disconnect() {
    * A private method used to re-establish a zookeeper session with a peer cluster.
    * @param ke
    */
-  protected void reconnect(KeeperException ke) {
+  private void reconnect(KeeperException ke) {

Review comment:
       This class is IA.Private, so it is not expected to be used by users. You can stop someone change this method this time but you can not stop them all the time. If you think this class should be used by users  so they can implement replication endpoint easier, let's promote this class to IA.LimitedPrivate?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org