You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@roller.apache.org by "Mark Thomas (JIRA)" <ji...@apache.org> on 2011/01/28 23:40:44 UTC
[jira] Created: (ROL-1906) Accept-Language header parsing broken
Accept-Language header parsing broken
-------------------------------------
Key: ROL-1906
URL: https://issues.apache.org/jira/browse/ROL-1906
Project: Roller
Issue Type: Bug
Affects Versions: 5.0
Environment: http://blogs.apache.org/
Reporter: Mark Thomas
Assignee: Roller Unassigned
The following request returns a 404 message in German when it should be in English. I have tested the underlying Tomcat ServletRequest.getLocale() implementation and that does return the correct value.
GET /foo/bar HTTP/1.1
Host: blogs.apache.org
Accept-Language: en,de;q=0.5
Version is Version 5.0.0-RC1 (r990388)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ROL-1906) Accept-Language header parsing broken
Posted by "David Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ROL-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Johnson updated ROL-1906:
-------------------------------
Priority: Minor (was: Major)
Fix Version/s: (was: 5.0)
This is a problem with the underlying JSTL implementation used on the Roller JSP pages and I am able to reproduce the error outside of Roller with a simple JSP page. JSTL is picking the wrong locale. Roller uses the latest JSTL implementation, so the proper course of action here is to report a bug to the JSTL developers and, if possible, create a work-around for Roller.
<%@ taglib uri="http://java.sun.com/jsp/jstl/core" prefix="c" %>
<%@ taglib uri="http://java.sun.com/jsp/jstl/fmt" prefix="fmt" %>
<fmt:setBundle basename="ApplicationResources" />
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title><fmt:message key="error.title.404" /></title>
Only the Roller editor/admin page is effected by this bug, not blog pages which use Servlet API directly.
This seems like a pretty minor issue, do "real users" really put Relative Quality Factors in their Accept-Langauge header?
> Accept-Language header parsing broken
> -------------------------------------
>
> Key: ROL-1906
> URL: https://issues.apache.org/jira/browse/ROL-1906
> Project: Roller
> Issue Type: Bug
> Affects Versions: 5.0
> Environment: http://blogs.apache.org/
> Reporter: Mark Thomas
> Assignee: Roller Unassigned
> Priority: Minor
>
> The following request returns a 404 message in German when it should be in English. I have tested the underlying Tomcat ServletRequest.getLocale() implementation and that does return the correct value.
> GET /foo/bar HTTP/1.1
> Host: blogs.apache.org
> Accept-Language: en,de;q=0.5
> Version is Version 5.0.0-RC1 (r990388)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ROL-1906) Accept-Language header parsing broken
Posted by "Mark Thomas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ROL-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999954#comment-12999954 ]
Mark Thomas commented on ROL-1906:
----------------------------------
This originated with a bug report to INFRA for the ASF roller installation so I'd have to say there is at least one user that uses quality factors in their Accept-Language header.
I agree the issue is a minor one.
> Accept-Language header parsing broken
> -------------------------------------
>
> Key: ROL-1906
> URL: https://issues.apache.org/jira/browse/ROL-1906
> Project: Roller
> Issue Type: Bug
> Affects Versions: 5.0
> Environment: http://blogs.apache.org/
> Reporter: Mark Thomas
> Assignee: Roller Unassigned
> Priority: Minor
>
> The following request returns a 404 message in German when it should be in English. I have tested the underlying Tomcat ServletRequest.getLocale() implementation and that does return the correct value.
> GET /foo/bar HTTP/1.1
> Host: blogs.apache.org
> Accept-Language: en,de;q=0.5
> Version is Version 5.0.0-RC1 (r990388)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ROL-1906) Accept-Language header parsing broken
Posted by "David Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ROL-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Johnson updated ROL-1906:
-------------------------------
Fix Version/s: 5.0
> Accept-Language header parsing broken
> -------------------------------------
>
> Key: ROL-1906
> URL: https://issues.apache.org/jira/browse/ROL-1906
> Project: Roller
> Issue Type: Bug
> Affects Versions: 5.0
> Environment: http://blogs.apache.org/
> Reporter: Mark Thomas
> Assignee: Roller Unassigned
> Fix For: 5.0
>
>
> The following request returns a 404 message in German when it should be in English. I have tested the underlying Tomcat ServletRequest.getLocale() implementation and that does return the correct value.
> GET /foo/bar HTTP/1.1
> Host: blogs.apache.org
> Accept-Language: en,de;q=0.5
> Version is Version 5.0.0-RC1 (r990388)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira