[jira] [Commented] (HBASE-16363) Correct javadoc for qualifier length and value length in Cell interface

["Xiang Li (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414883#comment-15414883 ] 

Xiang Li commented on HBASE-16363:
----------------------------------

[~anoop.hbase]
I uploaded patch 000 for master, which includes 2 fixes:

(1) Remove a part of the following comments for qualifier, to avoid mis-understanding.
bq. Contiguous raw bytes that may start at any index in the containing array. -Max length Short.MAX_VALUE which is 32,767 bytes.-
It is hard to use a short sentence to explain the qualifier max length (as you explained in the last comment), so I decide to remove that part

(2) For value length, Integer.MAX_VALUE is not 2,147,483,648 (=2^31), but 2^31-1. Just correct it

Do those make sense to you?

> Correct javadoc for qualifier length and value length in Cell interface
> -----------------------------------------------------------------------
>
>                 Key: HBASE-16363
>                 URL: https://issues.apache.org/jira/browse/HBASE-16363
>             Project: HBase
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Xiang Li
>            Assignee: Xiang Li
>            Priority: Minor
>
> In Cell interface (hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java)
> (1) We have the following comment for "qualifier"
> {code}
> /**
>   * Contiguous raw bytes that may start at any index in the containing array. Max length is
>   * Short.MAX_VALUE which is 32,767 bytes.
>   * @return The array containing the qualifier bytes.
>   */
> {code}
> But getQualifierLength() returns int
> {code}
> int getQualifierLength();
> {code}
> (2) We have the following comment for "value"
> {code}
>   /**
>    * Contiguous raw bytes that may start at any index in the containing array. Max length is
>    * Integer.MAX_VALUE which is 2,147,483,648 bytes.
>    * @return The array containing the value bytes.
>    */
> {code}
> Integer.MAX_VALUE is not 2,147,483,648 (2^31), but 2,147,483,647 (2^31-1)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)