You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ia...@apache.org on 2015/03/13 15:50:47 UTC
[1/2] cordova-plugin-contacts git commit: CB-8659: ios: 4.0.x
Compatibility: Remove use of initWebView method
Repository: cordova-plugin-contacts
Updated Branches:
refs/heads/master 0e38f7dae -> a464f35d2
CB-8659: ios: 4.0.x Compatibility: Remove use of initWebView method
Also deletes some long-dead code
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/commit/a464f35d
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/tree/a464f35d
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/diff/a464f35d
Branch: refs/heads/master
Commit: a464f35d2365ffa7838a1fac708a877a77511ccc
Parents: 5f89bec
Author: Ian Clelland <ic...@chromium.org>
Authored: Fri Mar 13 10:49:58 2015 -0400
Committer: Ian Clelland <ic...@chromium.org>
Committed: Fri Mar 13 10:50:34 2015 -0400
----------------------------------------------------------------------
src/ios/CDVContacts.m | 24 ------------------------
1 file changed, 24 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/blob/a464f35d/src/ios/CDVContacts.m
----------------------------------------------------------------------
diff --git a/src/ios/CDVContacts.m b/src/ios/CDVContacts.m
index 36f1898..372adcf 100644
--- a/src/ios/CDVContacts.m
+++ b/src/ios/CDVContacts.m
@@ -36,30 +36,6 @@
@implementation CDVContacts
-// no longer used since code gets AddressBook for each operation.
-// If address book changes during save or remove operation, may get error but not much we can do about it
-// If address book changes during UI creation, display or edit, we don't control any saves so no need for callback
-
-/*void addressBookChanged(ABAddressBookRef addressBook, CFDictionaryRef info, void* context)
-{
- // note that this function is only called when another AddressBook instance modifies
- // the address book, not the current one. For example, through an OTA MobileMe sync
- Contacts* contacts = (Contacts*)context;
- [contacts addressBookDirty];
- }*/
-
-- (CDVPlugin*)initWithWebView:(UIWebView*)theWebView
-{
- self = (CDVContacts*)[super initWithWebView:(UIWebView*)theWebView];
-
- /*if (self) {
- addressBook = ABAddressBookCreate();
- ABAddressBookRegisterExternalChangeCallback(addressBook, addressBookChanged, self);
- }*/
-
- return self;
-}
-
// overridden to clean up Contact statics
- (void)onAppTerminate
{
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[2/2] cordova-plugin-contacts git commit: CB-8659: ios: 4.0.x
Compatibility: Remove use of deprecated headers
Posted by ia...@apache.org.
CB-8659: ios: 4.0.x Compatibility: Remove use of deprecated headers
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/commit/5f89bece
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/tree/5f89bece
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/diff/5f89bece
Branch: refs/heads/master
Commit: 5f89bece7516dea124ccdb0d8eaae49c918f3e50
Parents: 0e38f7d
Author: Ian Clelland <ic...@chromium.org>
Authored: Fri Mar 13 10:47:57 2015 -0400
Committer: Ian Clelland <ic...@chromium.org>
Committed: Fri Mar 13 10:50:34 2015 -0400
----------------------------------------------------------------------
src/ios/CDVContact.m | 1 -
src/ios/CDVContacts.m | 3 ---
2 files changed, 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/blob/5f89bece/src/ios/CDVContact.m
----------------------------------------------------------------------
diff --git a/src/ios/CDVContact.m b/src/ios/CDVContact.m
index 6ee569c..6af9287 100644
--- a/src/ios/CDVContact.m
+++ b/src/ios/CDVContact.m
@@ -18,7 +18,6 @@
*/
#import "CDVContact.h"
-#import <Cordova/NSDictionary+Extensions.h>
#define DATE_OR_NULL(dateObj) ((aDate != nil) ? (id)([aDate descriptionWithLocale:[NSLocale currentLocale]]) : (id)([NSNull null]))
#define IS_VALID_VALUE(value) ((value != nil) && (![value isKindOfClass:[NSNull class]]))
http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/blob/5f89bece/src/ios/CDVContacts.m
----------------------------------------------------------------------
diff --git a/src/ios/CDVContacts.m b/src/ios/CDVContacts.m
index f351c3b..36f1898 100644
--- a/src/ios/CDVContacts.m
+++ b/src/ios/CDVContacts.m
@@ -19,9 +19,6 @@
#import "CDVContacts.h"
#import <UIKit/UIKit.h>
-#import <Cordova/NSArray+Comparisons.h>
-#import <Cordova/NSDictionary+Extensions.h>
-//#import "CDVNotification.h"
@implementation CDVContactsPicker
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org