You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "lburgazzoli (via GitHub)" <gi...@apache.org> on 2023/07/04 12:08:14 UTC
[GitHub] [camel-quarkus] lburgazzoli opened a new pull request, #5053: chore: fix various build/compilation warnings
lburgazzoli opened a new pull request, #5053:
URL: https://github.com/apache/camel-quarkus/pull/5053
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on pull request #5053: chore: fix various build/compilation warnings
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #5053:
URL: https://github.com/apache/camel-quarkus/pull/5053#issuecomment-1621284709
> I don't know if it is a Quarkus issue or a misusage
Openend an issue to track this work: https://github.com/apache/camel-quarkus/issues/5056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #5053: chore: fix various build/compilation warnings
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #5053:
URL: https://github.com/apache/camel-quarkus/pull/5053#discussion_r1252730432
##########
extensions/management/runtime/src/main/resources/META-INF/quarkus-extension.yaml:
##########
@@ -25,9 +25,8 @@ name: "Camel Management"
description: "JMX management strategy and associated managed resources"
icon-url: "https://camel.apache.org/_/img/logo-d-f21b25ba38.svg"
metadata:
- unlisted: true
Review Comment:
Is JMX supported on GraalVM now? I know it was planned, I just want to make sure it happened already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on pull request #5053: chore: fix various build/compilation warnings
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #5053:
URL: https://github.com/apache/camel-quarkus/pull/5053#issuecomment-1621205797
@essobedo I'm facing some `ClassNotFoundException` related issues here about Groovy and jOOR when running the Native tests, like:
```
[error]: Build step org.apache.camel.quarkus.component.groovy.deployment.GroovyProcessor#configureLanguage threw an exception: java.lang.IllegalStateException: java.lang.ClassNotFoundException: org.apache.camel.quarkus.component.groovy.generated.Expression668axhkmpOfBwe2iixBEtT194721N7sqMJrOlgVZAJVxs61
```
```
[error]: Build step org.apache.camel.quarkus.component.joor.deployment.JoorProcessor#configureLanguage threw an exception: java.lang.IllegalStateException: java.lang.ClassNotFoundException: org.apache.camel.quarkus.component.joor.generated.Expression78EQYvzpgOCH7d9dbRcJQ89Oc7j47VuG0Nph92qsYLags61
```
I don't yet know how things works under the hood so any help would be appreciated :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on a diff in pull request #5053: chore: fix various build/compilation warnings
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #5053:
URL: https://github.com/apache/camel-quarkus/pull/5053#discussion_r1251974392
##########
pom.xml:
##########
@@ -192,12 +192,16 @@
<maven-release-plugin.version>3.0.0</maven-release-plugin.version>
<maven-resources-plugin.version>3.3.1</maven-resources-plugin.version>
<maven-scm-plugin.version>2.0.0</maven-scm-plugin.version>
- <maven-shade-plugin.version>3.4.1</maven-shade-plugin.version>
+ <maven-shade-plugin.version>3.5.0</maven-shade-plugin.version>
<!-- NOTE: We pin to this version due to https://github.com/apache/camel-quarkus/issues/723 -->
<maven-surefire-plugin.version>2.22.2</maven-surefire-plugin.version>
<os-maven-plugin.version>${os-maven-plugin-version}</os-maven-plugin.version>
<protobuf-maven-plugin.version>${protobuf-maven-plugin-version}</protobuf-maven-plugin.version>
<rpkgtests-maven-plugin.version>1.0.0</rpkgtests-maven-plugin.version>
+ <maven-clean-plugin.version>3.2.0</maven-clean-plugin.version>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #5053: chore: fix various build/compilation warnings
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #5053:
URL: https://github.com/apache/camel-quarkus/pull/5053#discussion_r1252740301
##########
integration-test-groups/aws2/aws2-s3/src/main/java/org/apache/camel/quarkus/component/aws2/s3/it/Aws2S3Resource.java:
##########
@@ -143,11 +141,15 @@ public Response read(@PathParam("bucketName") String bucketName, @PathParam("key
@GET
@Produces(MediaType.APPLICATION_JSON)
public List<String> objectKey() throws Exception {
- final List<S3Object> objects = (List<S3Object>) producerTemplate.requestBody(
+ final List<?> objects = producerTemplate.requestBody(
componentUri(AWS2S3Operations.listObjects),
null,
List.class);
- return objects.stream().map(S3Object::key).collect(Collectors.toList());
+
+ return objects.stream()
+ .map(S3Object.class::cast)
+ .map(S3Object::key)
+ .collect(Collectors.toList());
Review Comment:
👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] essobedo commented on pull request #5053: chore: fix various build/compilation warnings
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #5053:
URL: https://github.com/apache/camel-quarkus/pull/5053#issuecomment-1621242704
> > ecorderContext.classProxy
>
> ok so I will add a comment but I guess we whould report this to quarkus ? otherwhise the method may disappear at some point I guess
Yes, I guess so too, I can add it to my to-do list. I don't know if it is a Quarkus issue or a misusage, I could not investigate more so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] essobedo commented on a diff in pull request #5053: chore: fix various build/compilation warnings
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on code in PR #5053:
URL: https://github.com/apache/camel-quarkus/pull/5053#discussion_r1252732263
##########
extensions/management/runtime/src/main/resources/META-INF/quarkus-extension.yaml:
##########
@@ -25,9 +25,8 @@ name: "Camel Management"
description: "JMX management strategy and associated managed resources"
icon-url: "https://camel.apache.org/_/img/logo-d-f21b25ba38.svg"
metadata:
- unlisted: true
Review Comment:
Yes it is supported starting from v 23 but it is experimental
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on pull request #5053: chore: fix various build/compilation warnings
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #5053:
URL: https://github.com/apache/camel-quarkus/pull/5053#issuecomment-1623100037
@ppalaga @jamesnetherton let me know if there is anything you want me to change before merging it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] essobedo commented on pull request #5053: chore: fix various build/compilation warnings
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #5053:
URL: https://github.com/apache/camel-quarkus/pull/5053#issuecomment-1621228175
> @essobedo I'm facing some `ClassNotFoundException` related issues here about Groovy and jOOR when running the Native tests, like:
>
> ```
> [error]: Build step org.apache.camel.quarkus.component.groovy.deployment.GroovyProcessor#configureLanguage
> threw an exception: java.lang.IllegalStateException: java.lang.ClassNotFoundException:
> org.apache.camel.quarkus.component.groovy.generated.Expression668axhkmpOfBwe2iixBEtT194721N7sqMJrOlgVZAJVxs61
> ```
>
> ```
> [error]: Build step org.apache.camel.quarkus.component.joor.deployment.JoorProcessor#configureLanguage
> threw an exception: java.lang.IllegalStateException: java.lang.ClassNotFoundException:
> org.apache.camel.quarkus.component.joor.generated.Expression78EQYvzpgOCH7d9dbRcJQ89Oc7j47VuG0Nph92qsYLags61
> ```
>
> I don't yet know how things works under the hood so any help would be appreciated :)
It is because you replaced `recorderContext.classProxy` with `Class.forName` in the Groovy and Joor processors, I already tried it before as it is supposed to replace it but it did not work as you can see. Those classes are generated classes based on expressions extracted from the route definitions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #5053: chore: fix various build/compilation warnings
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #5053:
URL: https://github.com/apache/camel-quarkus/pull/5053#discussion_r1251964263
##########
pom.xml:
##########
@@ -192,12 +192,16 @@
<maven-release-plugin.version>3.0.0</maven-release-plugin.version>
<maven-resources-plugin.version>3.3.1</maven-resources-plugin.version>
<maven-scm-plugin.version>2.0.0</maven-scm-plugin.version>
- <maven-shade-plugin.version>3.4.1</maven-shade-plugin.version>
+ <maven-shade-plugin.version>3.5.0</maven-shade-plugin.version>
<!-- NOTE: We pin to this version due to https://github.com/apache/camel-quarkus/issues/723 -->
<maven-surefire-plugin.version>2.22.2</maven-surefire-plugin.version>
<os-maven-plugin.version>${os-maven-plugin-version}</os-maven-plugin.version>
<protobuf-maven-plugin.version>${protobuf-maven-plugin-version}</protobuf-maven-plugin.version>
<rpkgtests-maven-plugin.version>1.0.0</rpkgtests-maven-plugin.version>
+ <maven-clean-plugin.version>3.2.0</maven-clean-plugin.version>
Review Comment:
Sorry to nitpick - do you mind moving these maven-*-plugin props up with the others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli merged pull request #5053: chore: fix various build/compilation warnings
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli merged PR #5053:
URL: https://github.com/apache/camel-quarkus/pull/5053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on pull request #5053: chore: fix various build/compilation warnings
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #5053:
URL: https://github.com/apache/camel-quarkus/pull/5053#issuecomment-1621236239
> ecorderContext.classProxy
ok so I will add a comment but I guess we whould report this to quarkus ? otherwhise the method may disappear at some point I guess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] essobedo commented on a diff in pull request #5053: chore: fix various build/compilation warnings
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on code in PR #5053:
URL: https://github.com/apache/camel-quarkus/pull/5053#discussion_r1252733834
##########
extensions/management/runtime/src/main/resources/META-INF/quarkus-extension.yaml:
##########
@@ -25,9 +25,8 @@ name: "Camel Management"
description: "JMX management strategy and associated managed resources"
icon-url: "https://camel.apache.org/_/img/logo-d-f21b25ba38.svg"
metadata:
- unlisted: true
Review Comment:
It has been added by this PR https://github.com/oracle/graal/issues/4732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org