[jira] [Closed] (FLINK-18061) TableResult#collect should return closeable iterator to avoid resource leak

["Dawid Wysakowicz (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Wysakowicz closed FLINK-18061.
------------------------------------
    Resolution: Fixed

Fixed:
* master
** d27c88820dd8ed66dcd39bc488a26c4ccff1a41e
* 1.11
** 05cecd232e158703749ac4a9dac9bc63641bbf35

> TableResult#collect should return closeable iterator to avoid resource leak
> ---------------------------------------------------------------------------
>
>                 Key: FLINK-18061
>                 URL: https://issues.apache.org/jira/browse/FLINK-18061
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / API
>            Reporter: godfrey he
>            Assignee: godfrey he
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.11.0
>
>
> as discussed in ML: http://mail-archives.apache.org/mod_mbox/flink-dev/202005.mbox/%3cd4ee47e1-0214-aa2f-f5ac-c9daf708e98f@apache.org%3e, we should return a closeable iterator for TableResult#collect method *to avoid resource leak*. The suggested change is:
> {code:java}
> public interface TableResult {
>   CloseableIterator<Row> collect();
> }
> {code}
> we use existing {{org.apache.flink.util.CloseableIterator}} instead of additional api class, and {{CollectResultIterator}} can also inherit from {{CloseableIterator}}.
> This change does not break current api.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)