You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/10/29 19:38:43 UTC

[GitHub] [pinot] mayankshriv commented on a change in pull request #7664: Allow override distinctCount to segmentPartitionedDistinctCount

mayankshriv commented on a change in pull request #7664:
URL: https://github.com/apache/pinot/pull/7664#discussion_r739489180



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -144,6 +146,8 @@ public BaseBrokerRequestHandler(PinotConfiguration config, RoutingManager routin
     _defaultHllLog2m = _config.getProperty(CommonConstants.Helix.DEFAULT_HYPERLOGLOG_LOG2M_KEY,
         CommonConstants.Helix.DEFAULT_HYPERLOGLOG_LOG2M);
     _enableQueryLimitOverride = _config.getProperty(Broker.CONFIG_OF_ENABLE_QUERY_LIMIT_OVERRIDE, false);
+    _enableSegmentPartitionedDistinctCountOverride =

Review comment:
       Can this be query flag instead of config? Issue with config is that we need to then enforce the config is set on all instances.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org