[GitHub] [hudi] prashantwason commented on a change in pull request #4212: [HUDI-2925] Fix duplicate cleaning of same files when unfinished clean operations are present.

[GitBox <gi...@apache.org>]

prashantwason commented on a change in pull request #4212:
URL: https://github.com/apache/hudi/pull/4212#discussion_r778638096



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -708,15 +708,25 @@ public HoodieCleanMetadata clean(String cleanInstantTime, boolean skipLocking) t
    * @param skipLocking if this is triggered by another parent transaction, locking can be skipped.
    */
   public HoodieCleanMetadata clean(String cleanInstantTime, boolean scheduleInline, boolean skipLocking) throws HoodieIOException {
-    if (scheduleInline) {
-      scheduleTableServiceInternal(cleanInstantTime, Option.empty(), TableServiceType.CLEAN);
-    }
     LOG.info("Cleaner started");
     final Timer.Context timerContext = metrics.getCleanCtx();
     LOG.info("Cleaned failed attempts if any");
     CleanerUtils.rollbackFailedWrites(config.getFailedWritesCleanPolicy(),
         HoodieTimeline.CLEAN_ACTION, () -> rollbackFailedWrites(skipLocking));
-    HoodieCleanMetadata metadata = createTable(config, hadoopConf).clean(context, cleanInstantTime, skipLocking);
+
+    // If there are pending clean operations, attempt them before scheduling the next clean. This prevents the
+    // next clean from deciding to clean the same files which might be under clean from pending operations.
+    HoodieCleanMetadata metadata = null;
+    HoodieTable table = createTable(config, hadoopConf);

Review comment:
       >> yeah, I also feel the planner should ensure that clean plans are mutually exclusive.
   
   This is what I have implemented by performing unfinished clean operations before attempting to generate a new clean plan. 
   
   The other way of ensuring mutually exclusive clean plans by reading unfinished older clean plans which generating a new clean plan is overkill IMO.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org