[GitHub] [arrow] rok commented on a diff in pull request #34676: GH-34673: [C++][Parquet] Add Boolean Encoding benchmark for parquet

["rok (via GitHub)" <gi...@apache.org>]

rok commented on code in PR #34676:
URL: https://github.com/apache/arrow/pull/34676#discussion_r1144737465


##########
cpp/src/parquet/encoding_benchmark.cc:
##########
@@ -254,23 +255,59 @@ static void BM_PlainEncodingSpaced(benchmark::State& state) {
   state.SetBytesProcessed(state.iterations() * num_values * sizeof(CType));
 }
 
+template <>
+void BM_EncodingSpaced<BooleanType>(benchmark::State& state, Encoding::type encoding) {
+  using CType = bool;
+
+  const int num_values = static_cast<int>(state.range(0));
+  const double null_percent = static_cast<double>(state.range(1)) / 10000.0;

Review Comment:
   Given that `state.range(1) = MAX_RANGE = 65536` we're always testing for `null_percent = 6.5536`? Perhaps we'd rather pass this explicitly and benchmark for `0.5` and `1`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org