You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fesod.apache.org by "delei (via GitHub)" <gi...@apache.org> on 2025/10/25 03:11:09 UTC
[PR] feat: Introduced Workbook constant for maximum sheet name length validation [fesod]
delei opened a new pull request, #658:
URL: https://github.com/apache/fesod/pull/658
## Purpose of the pull request
Related #657
## What's changed?
Office requires that the name attribute be less than or equal to 31 characters in length and follow the character limitations for sheet-name.
- Introduced Workbook constant for maximum sheet name length validation in `ExcelWriterSheetBuilder`
## Checklist
- [x] I have read the [Contributor Guide](https://fesod.apache.org/community/contribution/).
- [x] I have written the necessary doc or comment.
- [x] I have added the necessary unit tests and all cases have passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org
Re: [PR] feat: Introduced Workbook constant for maximum sheet name length validation [fesod]
Posted by "delei (via GitHub)" <gi...@apache.org>.
delei merged PR #658:
URL: https://github.com/apache/fesod/pull/658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org
Re: [PR] feat: Introduced Workbook constant for maximum sheet name length validation [fesod]
Posted by "alaahong (via GitHub)" <gi...@apache.org>.
alaahong commented on code in PR #658:
URL: https://github.com/apache/fesod/pull/658#discussion_r2462454551
##########
fesod/src/test/java/org/apache/fesod/excel/writesheet/WriteSheetTest.java:
##########
@@ -136,6 +136,13 @@ private void testSheetOrderWithSheetName(ExcelTypeEnum excelTypeEnum) {
excelWriter.write(dataList(dataMap.get(sheetNo)), writeSheet);
Assertions.assertEquals(
sheetNo, excelWriter.writeContext().writeSheetHolder().getSheetNo());
+
+ sheetNo = 3;
+ writeSheet =
+ FastExcel.writerSheet(sheetNo, sheetNameList.get(sheetNo)).build();
+ excelWriter.write(dataList(dataMap.get(sheetNo)), writeSheet);
+ Assertions.assertEquals(
+ sheetNo, excelWriter.writeContext().writeSheetHolder().getSheetNo());
Review Comment:
as this enhancement focus on sheetName substring, how about to assert the name as expectation? sheetNo doesn't show the change point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org