You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "song bruce zhang (Code Review)" <ge...@cloudera.org> on 2016/06/01 03:02:53 UTC

[kudu-CR] fix compile error when compiling column_predicate-test.cc

song bruce zhang has posted comments on this change.

Change subject:  fix compile error when compiling column_predicate-test.cc
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3233/8//COMMIT_MSG
Commit Message:

Line 7:  fix compile error when compiling column_predicate-test.cc
> There's one more formatting issue here: looks like every line in the commit
Done


Line 10:  column_predicate-test.cc.
> Thanks for the additional detail. I have two follow-up questions:
1:gcc 4.9.3
2:yes, it is TestInclusiveRange in column_predicate-test.cc . i will be better if we can fix this by modifying the test


-- 
To view, visit http://gerrit.cloudera.org:8080/3233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f9a9634eeccd86616be80b004ecce596155bb57
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zs...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: song bruce zhang <zs...@gmail.com>
Gerrit-HasComments: Yes