You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by bi...@apache.org on 2016/12/09 06:31:59 UTC
kylin git commit: KYLIN-2263 display reasonable message when could
not load kafka dependency
Repository: kylin
Updated Branches:
refs/heads/master 01060b574 -> 9021c085e
KYLIN-2263 display reasonable message when could not load kafka dependency
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/9021c085
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/9021c085
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/9021c085
Branch: refs/heads/master
Commit: 9021c085e541457d3676c287a9be347a8d093037
Parents: 01060b5
Author: Billy Liu <bi...@apache.org>
Authored: Fri Dec 9 14:31:52 2016 +0800
Committer: Billy Liu <bi...@apache.org>
Committed: Fri Dec 9 14:31:52 2016 +0800
----------------------------------------------------------------------
.../kylin/rest/controller/CubeController.java | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/9021c085/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java
----------------------------------------------------------------------
diff --git a/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java b/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java
index aef1ffc..c38ec4c 100644
--- a/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java
+++ b/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java
@@ -259,14 +259,26 @@ public class CubeController extends BasicController {
/** Build/Rebuild a cube segment by source offset */
@RequestMapping(value = "/{cubeName}/build2", method = { RequestMethod.PUT })
@ResponseBody
- public JobInstance build(@PathVariable String cubeName, @RequestBody JobBuildRequest2 req) {
- return rebuild(cubeName, req);
+ public JobInstance build2(@PathVariable String cubeName, @RequestBody JobBuildRequest2 req) {
+ boolean existKafkaClient = false;
+ try {
+ Class<?> clazz = Class.forName("org.apache.kafka.clients.consumer.KafkaConsumer");
+ if (clazz != null) {
+ existKafkaClient = true;
+ }
+ } catch (ClassNotFoundException e) {
+ existKafkaClient = false;
+ }
+ if (!existKafkaClient) {
+ throw new InternalErrorException("Could not find Kafka dependency");
+ }
+ return rebuild2(cubeName, req);
}
/** Build/Rebuild a cube segment by source offset */
@RequestMapping(value = "/{cubeName}/rebuild2", method = { RequestMethod.PUT })
@ResponseBody
- public JobInstance rebuild(@PathVariable String cubeName, @RequestBody JobBuildRequest2 req) {
+ public JobInstance rebuild2(@PathVariable String cubeName, @RequestBody JobBuildRequest2 req) {
return buildInternal(cubeName, 0, 0, req.getSourceOffsetStart(), req.getSourceOffsetEnd(), req.getSourcePartitionOffsetStart(), req.getSourcePartitionOffsetEnd(), req.getBuildType(), req.isForce());
}
@@ -583,7 +595,7 @@ public class CubeController extends BasicController {
request.setSourceOffsetEnd(hole.getSourceOffsetEnd());
request.setSourcePartitionOffsetEnd(hole.getSourcePartitionOffsetEnd());
try {
- JobInstance job = build(cubeName, request);
+ JobInstance job = build2(cubeName, request);
jobs.add(job);
} catch (Exception e) {
// it may exceed the max allowed job number